Refactor PDFAttachmentView to be more class-like and to separate functionality into methods

This commit is contained in:
Tim van der Meij 2015-01-27 22:06:19 +01:00
parent 609e2a30e9
commit 733882ac25
2 changed files with 52 additions and 34 deletions

View File

@ -18,37 +18,54 @@
'use strict'; 'use strict';
var PDFAttachmentView = function documentAttachmentsView(options) { var PDFAttachmentView = (function PDFAttachmentViewClosure() {
var attachments = options.attachments; function PDFAttachmentView(options) {
var attachmentsView = options.attachmentsView; this.container = options.container;
while (attachmentsView.firstChild) { this.attachments = options.attachments;
attachmentsView.removeChild(attachmentsView.firstChild);
} }
PDFAttachmentView.prototype = {
reset: function PDFAttachmentView_reset() {
var container = this.container;
while (container.firstChild) {
container.removeChild(container.firstChild);
}
},
_bindLink: function PDFAttachmentView_bindLink(button, item) {
button.onclick = function downloadFile(e) {
var downloadManager = new DownloadManager();
var content = item.content;
var filename = item.filename;
downloadManager.downloadData(content, getFileName(filename), '');
return false;
};
},
render: function PDFAttachmentView_render() {
var attachments = this.attachments;
this.reset();
if (!attachments) { if (!attachments) {
return; return;
} }
function bindItemLink(domObj, item) { var names = Object.keys(attachments).sort(function(a, b) {
domObj.onclick = function documentAttachmentsViewOnclick(e) {
var downloadManager = new DownloadManager();
downloadManager.downloadData(item.content, getFileName(item.filename),
'');
return false;
};
}
var names = Object.keys(attachments).sort(function(a,b) {
return a.toLowerCase().localeCompare(b.toLowerCase()); return a.toLowerCase().localeCompare(b.toLowerCase());
}); });
for (var i = 0, ii = names.length; i < ii; i++) { for (var i = 0, len = names.length; i < len; i++) {
var item = attachments[names[i]]; var item = attachments[names[i]];
var div = document.createElement('div'); var div = document.createElement('div');
div.className = 'attachmentsItem'; div.className = 'attachmentsItem';
var button = document.createElement('button'); var button = document.createElement('button');
bindItemLink(button, item); this._bindLink(button, item);
button.textContent = getFileName(item.filename); button.textContent = getFileName(item.filename);
div.appendChild(button); div.appendChild(button);
attachmentsView.appendChild(div); this.container.appendChild(div);
} }
}; }
};
return PDFAttachmentView;
})();

View File

@ -985,14 +985,15 @@ var PDFViewerApplication = {
} }
}); });
pdfDocument.getAttachments().then(function(attachments) { pdfDocument.getAttachments().then(function(attachments) {
var attachmentsView = document.getElementById('attachmentsView'); var container = document.getElementById('attachmentsView');
self.attachments = new PDFAttachmentView({ self.attachments = new PDFAttachmentView({
attachments: attachments, container: container,
attachmentsView: attachmentsView attachments: attachments
}); });
self.attachments.render();
document.getElementById('viewAttachments').disabled = !attachments; document.getElementById('viewAttachments').disabled = !attachments;
if (!attachments && !attachmentsView.classList.contains('hidden')) { if (!attachments && !container.classList.contains('hidden')) {
self.switchSidebarView('thumbs'); self.switchSidebarView('thumbs');
} }
if (attachments && if (attachments &&