From 7272bb4894d82d4e23d42b937c670fb16d6076f5 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Fri, 18 Nov 2016 21:10:41 +0100 Subject: [PATCH] Prevent "unreachable code after return statement" warnings from `PDFPageView_paintOnSvg` in the addons Follow-up to PR 7738. --- web/pdf_page_view.js | 64 ++++++++++++++++++++++---------------------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/web/pdf_page_view.js b/web/pdf_page_view.js index d26712d41..c42bd1703 100644 --- a/web/pdf_page_view.js +++ b/web/pdf_page_view.js @@ -613,43 +613,43 @@ var PDFPageView = (function PDFPageViewClosure() { if (typeof PDFJSDev !== 'undefined' && PDFJSDev.test('FIREFOX || MOZCENTRAL || CHROME')) { return Promise.resolve('SVG rendering is not supported.'); - } + } else { + var cancelled = false; + var ensureNotCancelled = function () { + if (cancelled) { + throw 'cancelled'; + } + }; - var cancelled = false; - var ensureNotCancelled = function () { - if (cancelled) { - throw 'cancelled'; - } - }; - - var self = this; - var pdfPage = this.pdfPage; - var SVGGraphics = pdfjsLib.SVGGraphics; - var actualSizeViewport = this.viewport.clone({scale: CSS_UNITS}); - var promise = pdfPage.getOperatorList().then(function (opList) { - ensureNotCancelled(); - var svgGfx = new SVGGraphics(pdfPage.commonObjs, pdfPage.objs); - return svgGfx.getSVG(opList, actualSizeViewport).then(function (svg) { + var self = this; + var pdfPage = this.pdfPage; + var SVGGraphics = pdfjsLib.SVGGraphics; + var actualSizeViewport = this.viewport.clone({scale: CSS_UNITS}); + var promise = pdfPage.getOperatorList().then(function (opList) { ensureNotCancelled(); - self.svg = svg; - self.paintedViewport = actualSizeViewport; + var svgGfx = new SVGGraphics(pdfPage.commonObjs, pdfPage.objs); + return svgGfx.getSVG(opList, actualSizeViewport).then(function (svg) { + ensureNotCancelled(); + self.svg = svg; + self.paintedViewport = actualSizeViewport; - svg.style.width = wrapper.style.width; - svg.style.height = wrapper.style.height; - self.renderingState = RenderingStates.FINISHED; - wrapper.appendChild(svg); + svg.style.width = wrapper.style.width; + svg.style.height = wrapper.style.height; + self.renderingState = RenderingStates.FINISHED; + wrapper.appendChild(svg); + }); }); - }); - return { - promise: promise, - onRenderContinue: function (cont) { - cont(); - }, - cancel: function () { - cancelled = true; - } - }; + return { + promise: promise, + onRenderContinue: function (cont) { + cont(); + }, + cancel: function () { + cancelled = true; + } + }; + } }, /**