Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the Number.isInteger checks from XRef.fetchUncompressed (PR 8857 follow-up)

Browse Source 
Having ran the entire test-suite locally with these `Number.isInteger` checks removed, there wasn't a single test failure anywhere; see also PR 8857.
Hence everything points to this being completely unnecessary now, and by removing this code there's thus fewer function calls being made in `XRef.fetchUncompressed`.
This commit is contained in:
Jonas Jenwald 2019-11-27 13:42:07 +01:00
parent dcf998a1c1
commit 725566cfea
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/obj.js
View File

@ -1682,12 +1682,6 @@ var XRef = (function XRefClosure() {
var obj2 = parser.getObj();
var obj3 = parser.getObj();
if (!Number.isInteger(obj1)) {
obj1 = parseInt(obj1, 10);
}
if (!Number.isInteger(obj2)) {
obj2 = parseInt(obj2, 10);
}
if (obj1 !== num || obj2 !== gen || !(obj3 instanceof Cmd)) {
throw new XRefEntryException(`Bad (uncompressed) XRef entry: ${ref}`);
}