Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Convert TempImageFactory to a class, using static fields/methods

Browse Source 
Please refer to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields
This commit is contained in:
Jonas Jenwald 2021-10-17 13:42:21 +02:00
parent 89785a23f3
commit 7216511fbf
1 changed files with 32 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
web/pdf_thumbnail_view.js
View File

@ -36,16 +36,11 @@ const THUMBNAIL_WIDTH = 98; // px
* @property {IL10n} l10n - Localization service. * @property {IL10n} l10n - Localization service.
*/ */
const TempImageFactory = (function TempImageFactoryClosure() { class TempImageFactory {
let tempCanvasCache = null; static #tempCanvas = null;
return { static getCanvas(width, height) {
getCanvas(width, height) { const tempCanvas = (this.#tempCanvas ||= document.createElement("canvas"));
let tempCanvas = tempCanvasCache;
if (!tempCanvas) {
tempCanvas = document.createElement("canvas");
tempCanvasCache = tempCanvas;
}
tempCanvas.width = width; tempCanvas.width = width;
tempCanvas.height = height; tempCanvas.height = height;
@ -64,20 +59,19 @@ const TempImageFactory = (function TempImageFactoryClosure() {
ctx.fillRect(0, 0, width, height); ctx.fillRect(0, 0, width, height);
ctx.restore(); ctx.restore();
return [tempCanvas, tempCanvas.getContext("2d")]; return [tempCanvas, tempCanvas.getContext("2d")];
}, }
destroyCanvas() { static destroyCanvas() {
const tempCanvas = tempCanvasCache; const tempCanvas = this.#tempCanvas;
if (tempCanvas) { if (tempCanvas) {
// Zeroing the width and height causes Firefox to release graphics // Zeroing the width and height causes Firefox to release graphics
// resources immediately, which can greatly reduce memory consumption. // resources immediately, which can greatly reduce memory consumption.
tempCanvas.width = 0; tempCanvas.width = 0;
tempCanvas.height = 0; tempCanvas.height = 0;
} }
tempCanvasCache = null; this.#tempCanvas = null;
}, }
}; }
})();
/** /**
* @implements {IRenderableView} * @implements {IRenderableView}