From 7f53fb82a5a85a49bd57a37fcfd3dceca6150976 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Wed, 21 Jun 2023 13:13:53 +0200 Subject: [PATCH] Remove the `OverlayManager.unregister` method since it's completely unused This method was added only for consistency with the `register`-method, however it's never actually been used. To avoid including dead code in the builds, let's just remove the `unregister`-method for now. *Please note:* If this method ever becomes useful, it'll be trivial to revert this commit. --- web/overlay_manager.js | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/web/overlay_manager.js b/web/overlay_manager.js index 233c9f594..891e3a253 100644 --- a/web/overlay_manager.js +++ b/web/overlay_manager.js @@ -42,20 +42,6 @@ class OverlayManager { }); } - /** - * @param {HTMLDialogElement} dialog - The overlay's DOM element. - * @returns {Promise} A promise that is resolved when the overlay has been - * unregistered. - */ - async unregister(dialog) { - if (!this.#overlays.has(dialog)) { - throw new Error("The overlay does not exist."); - } else if (this.#active === dialog) { - throw new Error("The overlay cannot be removed while it is active."); - } - this.#overlays.delete(dialog); - } - /** * @param {HTMLDialogElement} dialog - The overlay's DOM element. * @returns {Promise} A promise that is resolved when the overlay has been