Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Faster unit-tests by using beforeAll/afterAll in api_spec.js

Browse Source 
In the API unit-tests, we're currently loading the `basicapi.pdf` before every sub-test in `PDFDocument` and `Page`, which slows down the unit-tests quite a bit.
Locally this patch reduces the run time for `gulp unittest` by at least 40% for me.
This commit is contained in:
Jonas Jenwald 2016-03-30 15:24:57 +02:00
parent bec4891f5d
commit 7163e1eff3
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/unit/api_spec.js
View File

@ -1,6 +1,6 @@
/* globals PDFJS, expect, it, describe, Promise, combineUrl,
/* globals PDFJS, expect, it, describe, Promise, combineUrl, beforeAll,
InvalidPDFException, MissingPDFException, StreamType, FontType,
PDFDocumentProxy, PasswordException, PasswordResponses,
PDFDocumentProxy, PasswordException, PasswordResponses, afterAll,
PDFPageProxy, createPromiseCapability, beforeEach, afterEach */
'use strict';
@ -310,7 +310,7 @@ describe('api', function() {
var loadingTask;
var doc;
beforeEach(function(done) {
beforeAll(function(done) {
loadingTask = PDFJS.getDocument(basicApiUrl);
loadingTask.promise.then(function(data) {
doc = data;
@ -318,7 +318,7 @@ describe('api', function() {
});
});
afterEach(function() {
afterAll(function() {
loadingTask.destroy();
});
@ -680,7 +680,7 @@ describe('api', function() {
var loadingTask;
var pdfDocument, page;
beforeEach(function(done) {
beforeAll(function(done) {
loadingTask = PDFJS.getDocument(basicApiUrl);
loadingTask.promise.then(function(doc) {
pdfDocument = doc;
@ -693,7 +693,7 @@ describe('api', function() {
});
});
afterEach(function() {
afterAll(function() {
loadingTask.destroy();
});