Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix (most) LGTM warnings

Browse Source 
Most of the warnings we don't really care about, and those are simply white-listed using inline comments; however two cases prompted actual code changes:

 - In `src/display/pattern_helper.js` the branch in question is indeed unreachable, and should thus be safe to remove. (This code originated in PR 4192, which is now over seven years ago.)

 - In `test/test.js`, the function in question indeed doesn't accept any arguments. (The patch also re-formats a string just above, which didn't seem worthy of a separated patch.)

This now leaves only *one* warning in the LGTM report, however that one is a false positive that we'll need to report upstream.
This commit is contained in:
Jonas Jenwald 2021-07-24 13:54:52 +02:00
parent 834a638aad
commit 70bac87fed
5 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/file_spec.js
View File

@ -67,7 +67,7 @@ class FileSpec {
if (!this._filename && this.root) { if (!this._filename && this.root) {
const filename = pickPlatformItem(this.root) || "unnamed"; const filename = pickPlatformItem(this.root) || "unnamed";
this._filename = stringToPDFString(filename) this._filename = stringToPDFString(filename)
.replace(/\\\\/g, "\\") .replace(/\\\\/g, "\\") // lgtm [js/double-escaping]
.replace(/\\\//g, "/") .replace(/\\\//g, "/")
.replace(/\\/g, "/"); .replace(/\\/g, "/");
} }

2
src/display/pattern_helper.js
View File

@ -192,8 +192,6 @@ function drawTriangle(data, context, p1, p2, p3, c1, c2, c3) {
let k; let k;
if (y < y1) { if (y < y1) {
k = 0; k = 0;
} else if (y1 === y2) {
k = 1;
} else { } else {
k = (y1 - y) / (y1 - y2); k = (y1 - y) / (y1 - y2);
} }

2
test/integration/scripting_spec.js
View File

@ -22,7 +22,7 @@ describe("Interaction", () => {
} }
await action(); await action();
await page.waitForFunction( await page.waitForFunction(
`document.querySelector("${selector.replace("\\", "\\\\")}").value !== ""` `document.querySelector("${selector.replace("\\", "\\\\")}").value !== ""` // lgtm [js/incomplete-sanitization]
); );
return page.$eval(selector, el => el.value); return page.$eval(selector, el => el.value);
} }

6
test/test.js
View File

@ -262,11 +262,9 @@ function startRefTest(masterMode, showRefImages) {
} else if (showRefImages && numEqFailures > 0) { } else if (showRefImages && numEqFailures > 0) {
console.log(); console.log();
console.log( console.log(
"Starting reftest harness to examine " + `Starting reftest harness to examine ${numEqFailures} eq test failures.`
numEqFailures +
" eq test failures."
); );
examineRefImages(numEqFailures); examineRefImages();
} }
} }

2
test/webserver.js
View File

@ -153,7 +153,7 @@ WebServer.prototype = {
fileSize = stats.size; fileSize = stats.size;
var isDir = stats.isDirectory(); var isDir = stats.isDirectory();
if (isDir && !/\/$/.test(pathPart)) { if (isDir && !/\/$/.test(pathPart)) {
res.setHeader("Location", pathPart + "/" + urlParts[2]); res.setHeader("Location", pathPart + "/" + urlParts[2]); // lgtm [js/server-side-unvalidated-url-redirection]
res.writeHead(301); res.writeHead(301);
res.end("Redirected", "utf8"); res.end("Redirected", "utf8");
return; return;