Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #14355 from Snuffleupagus/api-page-caches-Map

Browse Source 
Change `WorkerTransport.{pageCache, pagePromises}` from an Array to a Map
This commit is contained in:
Tim van der Meij 2021-12-11 13:00:11 +01:00 committed by GitHub
commit 70809a80ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
src/display/api.js
View File

@ -1666,7 +1666,6 @@ class PDFPageProxy {
*/ */
_destroy() { _destroy() {
this.destroyed = true; this.destroyed = true;
this._transport.pageCache[this._pageIndex] = null;
const waitOn = []; const waitOn = [];
for (const intentState of this._intentStates.values()) { for (const intentState of this._intentStates.values()) {
@ -2403,6 +2402,10 @@ if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("GENERIC")) {
class WorkerTransport { class WorkerTransport {
#docStats = null; #docStats = null;
#pageCache = new Map();
#pagePromises = new Map();
constructor(messageHandler, loadingTask, networkStream, params) { constructor(messageHandler, loadingTask, networkStream, params) {
this.messageHandler = messageHandler; this.messageHandler = messageHandler;
this.loadingTask = loadingTask; this.loadingTask = loadingTask;
@ -2432,9 +2435,6 @@ class WorkerTransport {
this._networkStream = networkStream; this._networkStream = networkStream;
this._fullReader = null; this._fullReader = null;
this._lastProgress = null; this._lastProgress = null;
this.pageCache = [];
this.pagePromises = [];
this.downloadInfoCapability = createPromiseCapability(); this.downloadInfoCapability = createPromiseCapability();
this.setupMessageHandler(); this.setupMessageHandler();
@ -2514,13 +2514,11 @@ class WorkerTransport {
const waitOn = []; const waitOn = [];
// We need to wait for all renderings to be completed, e.g. // We need to wait for all renderings to be completed, e.g.
// timeout/rAF can take a long time. // timeout/rAF can take a long time.
for (const page of this.pageCache) { for (const page of this.#pageCache.values()) {
if (page) { waitOn.push(page._destroy());
waitOn.push(page._destroy());
}
} }
this.pageCache.length = 0; this.#pageCache.clear();
this.pagePromises.length = 0; this.#pagePromises.clear();
// Allow `AnnotationStorage`-related clean-up when destroying the document. // Allow `AnnotationStorage`-related clean-up when destroying the document.
if (this.hasOwnProperty("annotationStorage")) { if (this.hasOwnProperty("annotationStorage")) {
this.annotationStorage.resetModified(); this.annotationStorage.resetModified();
@ -2751,16 +2749,15 @@ class WorkerTransport {
return; // Ignore any pending requests if the worker was terminated. return; // Ignore any pending requests if the worker was terminated.
} }
const page = this.pageCache[data.pageIndex]; const page = this.#pageCache.get(data.pageIndex);
page._startRenderPage(data.transparency, data.cacheKey); page._startRenderPage(data.transparency, data.cacheKey);
}); });
messageHandler.on("commonobj", data => { messageHandler.on("commonobj", ([id, type, exportedData]) => {
if (this.destroyed) { if (this.destroyed) {
return; // Ignore any pending requests if the worker was terminated. return; // Ignore any pending requests if the worker was terminated.
} }
const [id, type, exportedData] = data;
if (this.commonObjs.has(id)) { if (this.commonObjs.has(id)) {
return; return;
} }
@ -2818,14 +2815,13 @@ class WorkerTransport {
} }
}); });
messageHandler.on("obj", data => { messageHandler.on("obj", ([id, pageIndex, type, imageData]) => {
if (this.destroyed) { if (this.destroyed) {
// Ignore any pending requests if the worker was terminated. // Ignore any pending requests if the worker was terminated.
return; return;
} }
const [id, pageIndex, type, imageData] = data; const pageProxy = this.#pageCache.get(pageIndex);
const pageProxy = this.pageCache[pageIndex];
if (pageProxy.objs.has(id)) { if (pageProxy.objs.has(id)) {
return; return;
} }
@ -2924,9 +2920,10 @@ class WorkerTransport {
return Promise.reject(new Error("Invalid page request")); return Promise.reject(new Error("Invalid page request"));
} }
const pageIndex = pageNumber - 1; const pageIndex = pageNumber - 1,
if (pageIndex in this.pagePromises) { cachedPromise = this.#pagePromises.get(pageIndex);
return this.pagePromises[pageIndex]; if (cachedPromise) {
return cachedPromise;
} }
const promise = this.messageHandler const promise = this.messageHandler
.sendWithPromise("GetPage", { .sendWithPromise("GetPage", {
@ -2943,10 +2940,10 @@ class WorkerTransport {
this._params.ownerDocument, this._params.ownerDocument,
this._params.pdfBug this._params.pdfBug
); );
this.pageCache[pageIndex] = page; this.#pageCache.set(pageIndex, page);
return page; return page;
}); });
this.pagePromises[pageIndex] = promise; this.#pagePromises.set(pageIndex, promise);
return promise; return promise;
} }
@ -3088,15 +3085,13 @@ class WorkerTransport {
if (this.destroyed) { if (this.destroyed) {
return; // No need to manually clean-up when destruction has started. return; // No need to manually clean-up when destruction has started.
} }
for (let i = 0, ii = this.pageCache.length; i < ii; i++) { for (const page of this.#pageCache.values()) {
const page = this.pageCache[i];
if (!page) {
continue;
}
const cleanupSuccessful = page.cleanup(); const cleanupSuccessful = page.cleanup();
if (!cleanupSuccessful) { if (!cleanupSuccessful) {
throw new Error(`startCleanup: Page ${i + 1} is currently rendering.`); throw new Error(
`startCleanup: Page ${page.pageNumber} is currently rendering.`
);
} }
} }
this.commonObjs.clear(); this.commonObjs.clear();