From 7025b9f85964199f4cf1416f0100637d336d778f Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Sun, 12 Sep 2021 18:13:36 +0200
Subject: [PATCH] [src/core/writer.js] Support `null` values in the
 `writeValue` function

*This fixes something that I noticed, having recently looked at both the `Lexer.getObj` and `writeValue` code.*

Please note that I unfortunately don't have an example of a form where saving fails without this patch. However, given its overall simplicity and that unit-tests are added, it's hopefully deemed useful to fix this potential issue pro-actively rather than waiting for a bug report.

At this point one might, and rightly so, wonder if there's actually any real-world PDF documents where a `null` value is being used?
Unfortunately the answer is *yes*, and we have a couple of examples in the test-suite (although none of those are related to forms); please see: `issue1015`, `issue2642`, `issue10402`, `issue12823`, `issue13823`, and `pr12564`.
---
 src/core/writer.js       | 2 ++
 test/unit/writer_spec.js | 6 +++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/core/writer.js b/src/core/writer.js
index c79a06dbd..54a476d6f 100644
--- a/src/core/writer.js
+++ b/src/core/writer.js
@@ -89,6 +89,8 @@ function writeValue(value, buffer, transform) {
     writeDict(value, buffer, transform);
   } else if (isStream(value)) {
     writeStream(value, buffer, transform);
+  } else if (value === null) {
+    buffer.push("null");
   } else {
     warn(`Unhandled value in writer: ${typeof value}, please file a bug.`);
   }
diff --git a/test/unit/writer_spec.js b/test/unit/writer_spec.js
index 7f9284633..1cfb5a8d0 100644
--- a/test/unit/writer_spec.js
+++ b/test/unit/writer_spec.js
@@ -117,6 +117,9 @@ describe("Writer", function () {
       dict.set("J", true);
       dict.set("K", false);
 
+      dict.set("NullArr", [null, 10]);
+      dict.set("NullVal", null);
+
       const buffer = [];
       writeDict(dict, buffer, null);
 
@@ -125,7 +128,8 @@ describe("Writer", function () {
         "/E (\\(hello\\\\world\\)) /F [1.23 4.5 6] " +
         "/G << /H 123 /I << /Length 8>> stream\n" +
         "a stream\n" +
-        "endstream\n>> /J true /K false>>";
+        "endstream\n>> /J true /K false " +
+        "/NullArr [null 10] /NullVal null>>";
 
       expect(buffer.join("")).toEqual(expected);
     });