Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #12796 from Snuffleupagus/BaseTreeViewer._finishRendering

Browse Source 
Extract common functionality into a new `BaseTreeViewer._finishRendering` method
This commit is contained in:
Tim van der Meij 2020-12-30 14:05:21 +01:00 committed by GitHub
commit 6e55326343
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 17 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
web/base_tree_viewer.js
View File

@ -103,6 +103,20 @@ class BaseTreeViewer {
this._toggleTreeItem(this.container, !this._lastToggleIsShow);
}
/**
* @private
*/
_finishRendering(fragment, count, hasAnyNesting = false) {
if (hasAnyNesting) {
this.container.classList.add("treeWithDeepNesting");
this._lastToggleIsShow = !fragment.querySelector(".treeItemsHidden");
}
this.container.appendChild(fragment);
this._dispatchEvent(count);
}
render(params) {
throw new Error("Not implemented: render");
}

4
web/pdf_attachment_viewer.js
View File

@ -187,9 +187,7 @@ class PDFAttachmentViewer extends BaseTreeViewer {
attachmentsCount++;
}
this.container.appendChild(fragment);
this._dispatchEvent(attachmentsCount);
this._finishRendering(fragment, attachmentsCount);
}
/**

10
web/pdf_layer_viewer.js
View File

@ -174,16 +174,8 @@ class PDFLayerViewer extends BaseTreeViewer {
levelData.parent.appendChild(div);
}
}
if (hasAnyNesting) {
this.container.classList.add("treeWithDeepNesting");
this._lastToggleIsShow =
fragment.querySelectorAll(".treeItemsHidden").length === 0;
}
this.container.appendChild(fragment);
this._dispatchEvent(layersCount);
this._finishRendering(fragment, layersCount, hasAnyNesting);
}
/**

10
web/pdf_outline_viewer.js
View File

@ -171,16 +171,8 @@ class PDFOutlineViewer extends BaseTreeViewer {
outlineCount++;
}
}
if (hasAnyNesting) {
this.container.classList.add("treeWithDeepNesting");
this._lastToggleIsShow =
fragment.querySelectorAll(".treeItemsHidden").length === 0;
}
this.container.appendChild(fragment);
this._dispatchEvent(outlineCount);
this._finishRendering(fragment, outlineCount, hasAnyNesting);
}
}