Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the internal PDFScriptingManager._pageEventsReady boolean (PR 13074 follow-up)

Browse Source 
With the introduction of `PDFScriptingManager._closeCapability` in PR 13074, the pre-existing `PDFScriptingManager._pageEventsReady` boolean essentially became redundant.
Given that you always want to avoid tracking closely related state *separately*, since it's easy to introduce subtle bugs that way, we should just remove `PDFScriptingManager._pageEventsReady` now.

Obviously I *should* have done this already back in PR 13074, sorry about the churn here!
This commit is contained in:
Jonas Jenwald 2021-06-17 18:01:10 +02:00
parent 3264d409dd
commit 6dc5dd194f
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
web/pdf_scripting_manager.js
View File

@ -46,7 +46,6 @@ class PDFScriptingManager {
this._scripting = null; this._scripting = null;
this._mouseState = Object.create(null); this._mouseState = Object.create(null);
this._pageEventsReady = false;
this._ready = false; this._ready = false;
this._eventBus = eventBus; this._eventBus = eventBus;
@ -308,7 +307,6 @@ class PDFScriptingManager {
return; return;
} }
} }
delete detail.id; delete detail.id;
delete detail.siblings; delete detail.siblings;
@ -333,10 +331,8 @@ class PDFScriptingManager {
if (initialize) { if (initialize) {
this._closeCapability = createPromiseCapability(); this._closeCapability = createPromiseCapability();
this._pageEventsReady = true;
} }
if (!this._pageEventsReady) { if (!this._closeCapability) {
return; // Scripting isn't fully initialized yet. return; // Scripting isn't fully initialized yet.
} }
const pageView = this._pdfViewer.getPageView(/* index = */ pageNumber - 1); const pageView = this._pdfViewer.getPageView(/* index = */ pageNumber - 1);
@ -373,7 +369,7 @@ class PDFScriptingManager {
const pdfDocument = this._pdfDocument, const pdfDocument = this._pdfDocument,
visitedPages = this._visitedPages; visitedPages = this._visitedPages;
if (!this._pageEventsReady) { if (!this._closeCapability) {
return; // Scripting isn't fully initialized yet. return; // Scripting isn't fully initialized yet.
} }
if (this._pageOpenPending.has(pageNumber)) { if (this._pageOpenPending.has(pageNumber)) {
@ -481,7 +477,6 @@ class PDFScriptingManager {
this._scripting = null; this._scripting = null;
delete this._mouseState.isDown; delete this._mouseState.isDown;
this._pageEventsReady = false;
this._ready = false; this._ready = false;
this._destroyCapability?.resolve(); this._destroyCapability?.resolve();