Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update {PDFLinkService, PDFDocumentProperties}.setDocument to make the "url" parameter optional

Browse Source 
This way the resetting of `PDFLinkService`/`PDFDocumentProperties` instances, as is done in `PDFViewerApplication.close`, only requires passing in *one* `null` argument instead of two.
This commit is contained in:
Jonas Jenwald 2018-09-30 12:11:27 +02:00
parent b40fb3814a
commit 6da78bcc3f
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/app.js
View File

@ -595,8 +595,8 @@ let PDFViewerApplication = {
this.pdfThumbnailViewer.setDocument(null); this.pdfThumbnailViewer.setDocument(null);
this.pdfViewer.setDocument(null); this.pdfViewer.setDocument(null);
this.pdfLinkService.setDocument(null, null); this.pdfLinkService.setDocument(null);
this.pdfDocumentProperties.setDocument(null, null); this.pdfDocumentProperties.setDocument(null);
} }
this.store = null; this.store = null;
this.isInitialViewSet = false; this.isInitialViewSet = false;

4
web/pdf_document_properties.js
View File

@ -120,7 +120,7 @@ class PDFDocumentProperties {
return Promise.all([ return Promise.all([
info, info,
metadata, metadata,
contentDispositionFilename || getPDFFileNameFromURL(this.url), contentDispositionFilename || getPDFFileNameFromURL(this.url || ''),
this._parseFileSize(this.maybeFileSize), this._parseFileSize(this.maybeFileSize),
this._parseDate(info.CreationDate), this._parseDate(info.CreationDate),
this._parseDate(info.ModDate), this._parseDate(info.ModDate),
@ -187,7 +187,7 @@ class PDFDocumentProperties {
* @param {Object} pdfDocument - A reference to the PDF document. * @param {Object} pdfDocument - A reference to the PDF document.
* @param {string} url - The URL of the document. * @param {string} url - The URL of the document.
*/ */
setDocument(pdfDocument, url) { setDocument(pdfDocument, url = null) {
if (this.pdfDocument) { if (this.pdfDocument) {
this._reset(); this._reset();
this._updateUI(true); this._updateUI(true);

2
web/pdf_link_service.js
View File

@ -49,7 +49,7 @@ class PDFLinkService {
this._pagesRefCache = null; this._pagesRefCache = null;
} }
setDocument(pdfDocument, baseUrl) { setDocument(pdfDocument, baseUrl = null) {
this.baseUrl = baseUrl; this.baseUrl = baseUrl;
this.pdfDocument = pdfDocument; this.pdfDocument = pdfDocument;
this._pagesRefCache = Object.create(null); this._pagesRefCache = Object.create(null);