Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Skip failing FBF tests in Google Chrome when running makeref on the bots

Browse Source 
Note that this will still allow the FBF tests to run locally, and also on the bots when invoked with `test`/`browsertest` (to not lose all the FBF test-coverage), but will no longer prevent `makeref` from running successfully on the bots.
This commit is contained in:
Jonas Jenwald 2020-01-13 21:05:22 +01:00
parent 40f531ee87
commit 6ab3ba9519
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/test.js
View File

@ -472,7 +472,7 @@ function checkEq(task, results, browser, masterMode) {
}
}
function checkFBF(task, results, browser) {
function checkFBF(task, results, browser, masterMode) {
var numFBFFailures = 0;
var round0 = results[0],
round1 = results[1];
@ -487,6 +487,20 @@ function checkFBF(task, results, browser) {
continue;
}
if (r0Page.snapshot !== r1Page.snapshot) {
// The FBF tests fail intermittently in Google Chrome when run on the
// bots, ignoring `makeref` failures for now; see https://github.com/mozilla/pdf.js/pull/11491
if (masterMode && /chrom(e|ium)/i.test(browser)) {
console.log(
"TEST-SKIPPED | forward-back-forward test " +
task.id +
" | in " +
browser +
" | page" +
(page + 1)
);
continue;
}
console.log(
"TEST-UNEXPECTED-FAIL | forward-back-forward test " +
task.id +
@ -566,7 +580,7 @@ function checkRefTestResults(browser, id, results) {
checkEq(task, results, browser, session.masterMode);
break;
case "fbf":
checkFBF(task, results, browser);
checkFBF(task, results, browser, session.masterMode);
break;
case "load":
checkLoad(task, results, browser);