Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary duplication in the addChildren helper function (used by the ObjectLoader)

Browse Source 
Besides being fewer lines of code overall, this also avoids *one* `node instanceof Dict` check for both of the `Dict`/`Stream`-cases.
This commit is contained in:
Jonas Jenwald 2020-07-17 13:50:02 +02:00
parent ea8e432c45
commit 684a7b89ac
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/core/obj.js
View File

@ -2205,18 +2205,16 @@ const ObjectLoader = (function () {
}
function addChildren(node, nodesToVisit) {
if (node instanceof Dict || isStream(node)) {
const dict = node instanceof Dict ? node : node.dict;
for (const rawValue of dict.getRawValues()) {
if (mayHaveChildren(rawValue)) {
nodesToVisit.push(rawValue);
}
}
} else if (Array.isArray(node)) {
for (const value of node) {
if (mayHaveChildren(value)) {
nodesToVisit.push(value);
}
if (node instanceof Dict) {
node = node.getRawValues();
} else if (isStream(node)) {
node = node.dict.getRawValues();
} else if (!Array.isArray(node)) {
return;
}
for (const rawValue of node) {
if (mayHaveChildren(rawValue)) {
nodesToVisit.push(rawValue);
}
}
}