Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #16990 from calixteman/alt_text_aria_label

Browse Source 
[Editor] Add an aria-label to the alt-text button depending on its state
This commit is contained in:
calixteman 2023-09-21 10:56:25 +02:00 committed by GitHub
commit 67ddabcbc2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
l10n/en-US/viewer.properties
View File

@ -268,6 +268,7 @@ editor_ink_canvas_aria_label=User-created image
# LOCALIZATION NOTE (editor_alt_text_button_label): Alternative text (alt text) helps
# when people can't see the image.
editor_alt_text_button_label=Alt text
editor_alt_text_edit_button_label=Edit alt text
editor_alt_text_dialog_label=Choose an option
editor_alt_text_dialog_description=Alt text (alternative text) helps when people can’t see the image or when it doesn’t load.
editor_alt_text_add_description_label=Add a description

8
src/display/editor/editor.js
View File

@ -150,6 +150,7 @@ class AnnotationEditor {
AnnotationEditor._l10nPromise ||= new Map(
[
"editor_alt_text_button_label",
"editor_alt_text_edit_button_label",
"editor_alt_text_decorative_tooltip",
].map(str => [str, l10n.get(str)])
);
@ -831,6 +832,7 @@ class AnnotationEditor {
.get("editor_alt_text_button_label")
.then(msg => {
altText.textContent = msg;
altText.setAttribute("aria-label", msg);
});
altText.tabIndex = "0";
altText.addEventListener(
@ -865,6 +867,12 @@ class AnnotationEditor {
if (!button || (!this.#altTextDecorative && !this.#altText)) {
return;
}
AnnotationEditor._l10nPromise
.get("editor_alt_text_edit_button_label")
.then(msg => {
button.setAttribute("aria-label", msg);
});
let tooltip = this.#altTextTooltip;
if (!tooltip) {
this.#altTextTooltip = tooltip = document.createElement("span");

1
web/l10n_utils.js
View File

@ -83,6 +83,7 @@ const DEFAULT_L10N_STRINGS = {
editor_ink2_aria_label: "Draw Editor",
editor_ink_canvas_aria_label: "User-created image",
editor_alt_text_button_label: "Alt text",
editor_alt_text_edit_button_label: "Edit alt text",
editor_alt_text_decorative_tooltip: "Marked as decorative",
};
if (typeof PDFJSDev === "undefined" || !PDFJSDev.test("MOZCENTRAL")) {