Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace a couple of Array.prototype.forEach-invocations with for..of instead

Browse Source 
Given that `NodeList`s can be iterated using `for..of` we can use that instead, since it's a little bit nicer and easier to read than the `Array.prototype.forEach` format.
This commit is contained in:
Jonas Jenwald 2021-10-01 09:06:17 +02:00
parent 09361a4bb4
commit 67a642c826
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/display/annotation_layer.js
View File

@ -1404,12 +1404,11 @@ class ChoiceWidgetAnnotationElement extends WidgetAnnotationElement {
selectElement.addEventListener("updatefromsandbox", jsEvent => { selectElement.addEventListener("updatefromsandbox", jsEvent => {
const actions = { const actions = {
value(event) { value(event) {
const options = selectElement.options;
const value = event.detail.value; const value = event.detail.value;
const values = new Set(Array.isArray(value) ? value : [value]); const values = new Set(Array.isArray(value) ? value : [value]);
Array.prototype.forEach.call(options, option => { for (const option of selectElement.options) {
option.selected = values.has(option.value); option.selected = values.has(option.value);
}); }
storage.setValue(id, { storage.setValue(id, {
value: getValue(event, /* isExport */ true), value: getValue(event, /* isExport */ true),
}); });
@ -1478,10 +1477,9 @@ class ChoiceWidgetAnnotationElement extends WidgetAnnotationElement {
}, },
indices(event) { indices(event) {
const indices = new Set(event.detail.indices); const indices = new Set(event.detail.indices);
const options = event.target.options; for (const option of event.target.options) {
Array.prototype.forEach.call(options, (option, i) => { option.selected = indices.has(option.index);
option.selected = indices.has(i); }
});
storage.setValue(id, { storage.setValue(id, {
value: getValue(event, /* isExport */ true), value: getValue(event, /* isExport */ true),
}); });