Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adjust how AnnotationBorderStyle.setWidth handles the input being a Name (issue 10385)

Browse Source 
In order to be consistent with the behaviour in Adobe Reader, the width will now always be set to zero when the input is a `Name`.
This commit is contained in:
Jonas Jenwald 2019-01-04 10:33:15 +01:00
parent 5a2bd9fc63
commit 66fccd860b
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/core/annotation.js
View File

@ -485,7 +485,8 @@ class AnnotationBorderStyle {
// Some corrupt PDF generators may provide the width as a `Name`, // Some corrupt PDF generators may provide the width as a `Name`,
// rather than as a number (fixes issue 10385). // rather than as a number (fixes issue 10385).
if (isName(width)) { if (isName(width)) {
width = parseFloat(width.name); this.width = 0; // This is consistent with the behaviour in Adobe Reader.
return;
} }
if (Number.isInteger(width)) { if (Number.isInteger(width)) {
this.width = width; this.width = width;

11
test/unit/annotation_spec.js
View File

@ -236,12 +236,15 @@ describe('annotation', function() {
expect(borderStyle.width).toEqual(1); expect(borderStyle.width).toEqual(1);
}); });
it('should set/get a valid width, when the input is a `Name` (issue 10385)', it('should set the width to zero, when the input is a `Name` (issue 10385)',
function() { function() {
const borderStyle = new AnnotationBorderStyle(); const borderStyleZero = new AnnotationBorderStyle();
borderStyle.setWidth(Name.get('0')); borderStyleZero.setWidth(Name.get('0'));
const borderStyleFive = new AnnotationBorderStyle();
borderStyleFive.setWidth(Name.get('5'));
expect(borderStyle.width).toEqual(0); expect(borderStyleZero.width).toEqual(0);
expect(borderStyleFive.width).toEqual(0);
}); });
it('should set and get a valid style', function() { it('should set and get a valid style', function() {