Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent Firefox from warning about |unreachable code after return statement|

Browse Source 
*This is a follow-up to PR 5966.*

Now that https://bugzilla.mozilla.org/show_bug.cgi?id=1151931 has landed, we're unfortunately in a situation where Firefox warns about `unreachable code after return statement` multiple times when using the PDF.js code in `node make server` mode.

I'm really sorry about the churn in this code!
However I don't think it's a good idea to let Firefox continue to printing these warnings in the console, since it increases the risk of missing actual errors.
This commit is contained in:
Jonas Jenwald 2015-04-29 19:09:58 +02:00
parent 4824baf31c
commit 66b12974c9
1 changed files with 19 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
web/viewer.js
View File

@ -598,10 +598,12 @@ var PDFViewerApplication = {
},
fallback: function pdfViewFallback(featureId) {
//#if !(FIREFOX || MOZCENTRAL)
/* jshint -W027 */
return;
//#else
//#if !PRODUCTION
if (true) {
return;
}
//#endif
//#if (FIREFOX || MOZCENTRAL)
// Only trigger the fallback once so we don't spam the user with messages
// for one PDF.
if (this.fellback) {
@ -1037,8 +1039,9 @@ var PDFViewerApplication = {
}
//#if !PRODUCTION
/* jshint -W027 */
return;
if (true) {
return;
}
//#endif
//#if (FIREFOX || MOZCENTRAL)
var versionId = String(info.PDFFormatVersion).slice(-1) | 0;
@ -1316,8 +1319,9 @@ var PDFViewerApplication = {
}
//#if !PRODUCTION
/* jshint -W027 */
return;
if (true) {
return;
}
//#endif
//#if (FIREFOX || MOZCENTRAL)
FirefoxCom.request('reportTelemetry', JSON.stringify({
@ -1694,8 +1698,9 @@ document.addEventListener('pagerendered', function (e) {
}
//#if !PRODUCTION
/* jshint -W027 */
return;
if (true) {
return;
}
//#endif
//#if (FIREFOX || MOZCENTRAL)
FirefoxCom.request('reportTelemetry', JSON.stringify({
@ -1716,8 +1721,9 @@ document.addEventListener('textlayerrendered', function (e) {
var pageView = PDFViewerApplication.pdfViewer.getPageView(pageIndex);
//#if !PRODUCTION
/* jshint -W027 */
return;
if (true) {
return;
}
//#endif
//#if (FIREFOX || MOZCENTRAL)
if (pageView.textLayer && pageView.textLayer.textDivs &&
@ -1805,7 +1811,7 @@ window.addEventListener('hashchange', function webViewerHashchange(evt) {
}
});
//#if !(FIREFOX || MOZCENTRAL || CHROME)
//#if GENERIC
window.addEventListener('change', function webViewerChange(evt) {
var files = evt.target.files;
if (!files || files.length === 0) {