From 66a56718476d9622aed2d5a2a9b38d29c2d47407 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Fri, 4 Jun 2021 12:53:19 +0200 Subject: [PATCH] Remove `gulp makefile`, since it's broken and unused Looking at the history of the code, this `gulp` task was *accidentally* broken in the Gulp 4 upgrade in PR 10266 (all the way back in 2018). Given that no one has either noticed and/or complained about this since, it's safe to assume that it's completely unused, hence why I suggest that we just remove this `gulp` task (rather than fixing it). --- gulpfile.js | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index a2f75a750..7b8b46727 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -13,7 +13,6 @@ * limitations under the License. */ /* eslint-env node */ -/* globals target */ "use strict"; @@ -1848,17 +1847,6 @@ gulp.task("clean", function (done) { rimraf(BUILD_DIR, done); }); -gulp.task("makefile", function () { - let makefileContent = "help:\n\tgulp\n\n"; - const targetsNames = []; - for (const i in target) { - makefileContent += i + ":\n\tgulp " + i + "\n\n"; - targetsNames.push(i); - } - makefileContent += ".PHONY: " + targetsNames.join(" ") + "\n"; - return createStringSource("Makefile", makefileContent).pipe(gulp.dest(".")); -}); - gulp.task("importl10n", function (done) { const locales = require("./external/importL10n/locales.js");