From 65fe0130f432945636cf3c3939987f8cb63bb4b4 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sat, 28 May 2022 08:41:25 +0200 Subject: [PATCH] Handle CSS-comments correctly in the `preprocess`-function (PR 14886 follow-up) I overlooked this in PR 14886, sorry about that! --- external/builder/builder.js | 4 +++- external/builder/fixtures/css-comment-expected.css | 4 ++++ external/builder/fixtures/css-comment.css | 6 ++++++ 3 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 external/builder/fixtures/css-comment-expected.css create mode 100644 external/builder/fixtures/css-comment.css diff --git a/external/builder/builder.js b/external/builder/builder.js index d63d7e637..2666594d5 100644 --- a/external/builder/builder.js +++ b/external/builder/builder.js @@ -208,7 +208,9 @@ function preprocess(inFilename, outFilename, defines) { !stack.includes(STATE_IF_FALSE) && !stack.includes(STATE_ELSE_FALSE) ) { - writeLine(line.replace(/^\/\/|^$/g, "")); + writeLine( + line.replace(/^\/\/|^\/\*|^$/g, "") + ); } } } diff --git a/external/builder/fixtures/css-comment-expected.css b/external/builder/fixtures/css-comment-expected.css new file mode 100644 index 000000000..52776297b --- /dev/null +++ b/external/builder/fixtures/css-comment-expected.css @@ -0,0 +1,4 @@ +/* Comment here... */ + div { + margin: 0; + } diff --git a/external/builder/fixtures/css-comment.css b/external/builder/fixtures/css-comment.css new file mode 100644 index 000000000..3d22a0f69 --- /dev/null +++ b/external/builder/fixtures/css-comment.css @@ -0,0 +1,6 @@ +/* Comment here... */ +/*#if TRUE*/ +/*div {*/ +/* margin: 0;*/ +/*}*/ +/*#endif*/