Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix bug in scrollIntoView

Browse Source 
Prior to this commit, if the vertical scroll bar is absent and the horizontal
scroll bar is present, a link to a particular point on the page which should
induce a horizontal scroll did not do so, because the absence of a vertical
scroll bar meant that the viewer was not recognized as the nearest scrolling
ancestor. This commit adds a check for horizontal scroll bars when searching
for the scrolling ancestor.
This commit is contained in:
Ryan Hendrickson 2018-05-14 23:10:32 -04:00
parent c5c06bf5c4
commit 65c8549759
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
web/ui_utils.js
View File

@ -115,7 +115,8 @@ function scrollIntoView(element, spot, skipOverflowHiddenElements = false) {
} }
let offsetY = element.offsetTop + element.clientTop; let offsetY = element.offsetTop + element.clientTop;
let offsetX = element.offsetLeft + element.clientLeft; let offsetX = element.offsetLeft + element.clientLeft;
while (parent.clientHeight === parent.scrollHeight || while ((parent.clientHeight === parent.scrollHeight &&
parent.clientWidth === parent.scrollWidth) ||
(skipOverflowHiddenElements && (skipOverflowHiddenElements &&
getComputedStyle(parent).overflow === 'hidden')) { getComputedStyle(parent).overflow === 'hidden')) {
if (parent.dataset._scaleY) { if (parent.dataset._scaleY) {