From 6ab3ba95193e7ff287b7d982cc011742603c3c61 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Mon, 13 Jan 2020 21:05:22 +0100 Subject: [PATCH] Skip failing FBF tests in Google Chrome when running `makeref` on the bots Note that this will still allow the FBF tests to run locally, and also on the bots when invoked with `test`/`browsertest` (to not lose all the FBF test-coverage), but will no longer prevent `makeref` from running successfully on the bots. --- test/test.js | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/test/test.js b/test/test.js index d5f991f60..38eafb4e9 100644 --- a/test/test.js +++ b/test/test.js @@ -472,7 +472,7 @@ function checkEq(task, results, browser, masterMode) { } } -function checkFBF(task, results, browser) { +function checkFBF(task, results, browser, masterMode) { var numFBFFailures = 0; var round0 = results[0], round1 = results[1]; @@ -487,6 +487,20 @@ function checkFBF(task, results, browser) { continue; } if (r0Page.snapshot !== r1Page.snapshot) { + // The FBF tests fail intermittently in Google Chrome when run on the + // bots, ignoring `makeref` failures for now; see https://github.com/mozilla/pdf.js/pull/11491 + if (masterMode && /chrom(e|ium)/i.test(browser)) { + console.log( + "TEST-SKIPPED | forward-back-forward test " + + task.id + + " | in " + + browser + + " | page" + + (page + 1) + ); + continue; + } + console.log( "TEST-UNEXPECTED-FAIL | forward-back-forward test " + task.id + @@ -566,7 +580,7 @@ function checkRefTestResults(browser, id, results) { checkEq(task, results, browser, session.masterMode); break; case "fbf": - checkFBF(task, results, browser); + checkFBF(task, results, browser, session.masterMode); break; case "load": checkLoad(task, results, browser);