Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid when it's possible to use Array.concat when compiling a CFF font

Browse Source 
In looking at https://bugs.ghostscript.com/show_bug.cgi?id=706451 I noticed that bug2.pdf was pretty
slow to load for such a basic file.
In profiling I noticed that a lot of time is spent in Array.concat, hence this patch use Array.push when
it's possible (it's now ~3 times faster).
This commit is contained in:
Calixte Denizet 2023-04-14 15:07:31 +02:00
parent 342dc760da
commit 5eab8ec610
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/core/cff_parser.js
View File

@ -1383,7 +1383,13 @@ class CFFCompiler {
data: [],
length: 0,
add(data) {
this.data = this.data.concat(data);
if (data.length <= 65536) {
// The number of arguments is limited, hence we just take 65536 as
// limit because it isn't too high or too low.
this.data.push(...data);
} else {
this.data = this.data.concat(data);
}
this.length = this.data.length;
},
};