From 816ffa29aa8fd4237e569d9d8b8a23c41a3c9d42 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sun, 15 Oct 2017 16:57:30 +0200 Subject: [PATCH] Remove all warning/fallback code for obsolete method signatures in `web/` files --- web/app.js | 12 +----------- web/base_viewer.js | 5 ----- web/pdf_link_service.js | 8 -------- 3 files changed, 1 insertion(+), 24 deletions(-) diff --git a/web/app.js b/web/app.js index ed5e6fbe2..7f6b058b3 100644 --- a/web/app.js +++ b/web/app.js @@ -633,11 +633,6 @@ let PDFViewerApplication = { * is opened. */ open(file, args) { - if ((typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC')) && - (arguments.length > 2 || typeof args === 'number')) { - return Promise.reject( - new Error('Call of open() with obsolete signature.')); - } if (this.pdfLoadingTask) { // We need to destroy already opened document. return this.close().then(() => { @@ -667,12 +662,7 @@ let PDFViewerApplication = { if (args) { for (let prop in args) { - if ((typeof PDFJSDev === 'undefined' || !PDFJSDev.test('PDFJS_NEXT')) && - !PDFJS.pdfjsNext && prop === 'scale') { - console.error('Call of open() with obsolete "scale" argument, ' + - 'please use the "defaultZoomValue" preference instead.'); - continue; - } else if (prop === 'length') { + if (prop === 'length') { this.pdfDocumentProperties.setFileSize(args[prop]); } parameters[prop] = args[prop]; diff --git a/web/base_viewer.js b/web/base_viewer.js index dcb7125de..bc953977e 100644 --- a/web/base_viewer.js +++ b/web/base_viewer.js @@ -601,11 +601,6 @@ class BaseViewer { * @param {ScrollPageIntoViewParameters} params */ scrollPageIntoView(params) { - if ((typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC')) && - (arguments.length > 1 || typeof params === 'number')) { - console.error('Call of scrollPageIntoView() with obsolete signature.'); - return; - } if (!this.pdfDocument) { return; } diff --git a/web/pdf_link_service.js b/web/pdf_link_service.js index 5822098df..aecd66c91 100644 --- a/web/pdf_link_service.js +++ b/web/pdf_link_service.js @@ -260,14 +260,6 @@ class PDFLinkService { }); } } else { // Named (or explicit) destination. - if ((typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC')) && - /^\d+$/.test(hash) && hash <= this.pagesCount) { - console.warn('PDFLinkService_setHash: specifying a page number ' + - 'directly after the hash symbol (#) is deprecated, ' + - `please use the "#page=${hash}" form instead.`); - this.page = hash | 0; - } - dest = unescape(hash); try { dest = JSON.parse(dest);