From 5d080a03bb9af28a133c3e7c94018c6128ca170d Mon Sep 17 00:00:00 2001 From: Brendan Dahl Date: Tue, 7 Jan 2014 16:03:45 -0800 Subject: [PATCH] =?UTF-8?q?Show=20a=20different=20warning=20for=20PDF?= =?UTF-8?q?=E2=80=99s=20with=20forms.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- extensions/firefox/components/PdfStreamConverter.js | 9 +++++++-- l10n/en-US/chrome.properties | 1 + web/viewer.js | 2 +- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/extensions/firefox/components/PdfStreamConverter.js b/extensions/firefox/components/PdfStreamConverter.js index 91ef062e6..504fbc47b 100644 --- a/extensions/firefox/components/PdfStreamConverter.js +++ b/extensions/firefox/components/PdfStreamConverter.js @@ -377,11 +377,16 @@ ChromeActions.prototype = { break; } }, - fallback: function(url, sendResponse) { + fallback: function(featureId, url, sendResponse) { var self = this; var domWindow = this.domWindow; var strings = getLocalizedStrings('chrome.properties'); - var message = getLocalizedString(strings, 'unsupported_feature'); + var message; + if (featureId === 'forms') { + message = getLocalizedString(strings, 'unsupported_feature_forms'); + } else { + message = getLocalizedString(strings, 'unsupported_feature'); + } PdfJsTelemetry.onFallback(); diff --git a/l10n/en-US/chrome.properties b/l10n/en-US/chrome.properties index 0b469195c..e42ac790c 100644 --- a/l10n/en-US/chrome.properties +++ b/l10n/en-US/chrome.properties @@ -14,5 +14,6 @@ # Chrome notification bar messages and buttons unsupported_feature=This PDF document might not be displayed correctly. +unsupported_feature_forms=This PDF document contains forms. The filling of form fields is not supported. open_with_different_viewer=Open With Different Viewer open_with_different_viewer.accessKey=o diff --git a/web/viewer.js b/web/viewer.js index 84dd5ea07..be90b1750 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -609,7 +609,7 @@ var PDFView = { // return; // this.fellback = true; // var url = this.url.split('#')[0]; -// FirefoxCom.request('fallback', url, function response(download) { +// FirefoxCom.request('fallback', featureId, url, function response(download) { // if (!download) // return; // PDFView.download();