Enable the eslint-plugin-no-unsanitized ESLint plugin to disallow unsafe usage of e.g. innerHTML
				
					
				
			See https://github.com/mozilla/eslint-plugin-no-unsanitized Since we've generally never allowed e.g. `innerHTML`, which is enforced during review, there's only one linting failure with this patch. (Which is white-listed, according to the existing comment and the fact that it's test-only code.)
This commit is contained in:
		
							parent
							
								
									1c9a69db82
								
							
						
					
					
						commit
						5bb5e7741d
					
				| @ -7,6 +7,7 @@ | |||||||
|   "plugins": [ |   "plugins": [ | ||||||
|     "import", |     "import", | ||||||
|     "mozilla", |     "mozilla", | ||||||
|  |     "no-unsanitized", | ||||||
|     "unicorn", |     "unicorn", | ||||||
|   ], |   ], | ||||||
| 
 | 
 | ||||||
| @ -28,6 +29,8 @@ | |||||||
|     "import/no-unresolved": "error", |     "import/no-unresolved": "error", | ||||||
|     "mozilla/avoid-removeChild": "error", |     "mozilla/avoid-removeChild": "error", | ||||||
|     "mozilla/use-includes-instead-of-indexOf": "error", |     "mozilla/use-includes-instead-of-indexOf": "error", | ||||||
|  |     "no-unsanitized/method": "error", | ||||||
|  |     "no-unsanitized/property": "error", | ||||||
|     "unicorn/no-array-instanceof": "error", |     "unicorn/no-array-instanceof": "error", | ||||||
| 
 | 
 | ||||||
|     // Possible errors |     // Possible errors | ||||||
|  | |||||||
| @ -12,6 +12,7 @@ | |||||||
|  * See the License for the specific language governing permissions and |  * See the License for the specific language governing permissions and | ||||||
|  * limitations under the License. |  * limitations under the License. | ||||||
|  */ |  */ | ||||||
|  | /* eslint-disable no-unsanitized/method */ | ||||||
| 
 | 
 | ||||||
| import { assert, ImageKind, OPS } from '../shared/util'; | import { assert, ImageKind, OPS } from '../shared/util'; | ||||||
| 
 | 
 | ||||||
|  | |||||||
| @ -627,6 +627,7 @@ var Driver = (function DriverClosure() { // eslint-disable-line no-unused-vars | |||||||
|       // Using insertAdjacentHTML yields a large performance gain and
 |       // Using insertAdjacentHTML yields a large performance gain and
 | ||||||
|       // reduces runtime significantly.
 |       // reduces runtime significantly.
 | ||||||
|       if (this.output.insertAdjacentHTML) { |       if (this.output.insertAdjacentHTML) { | ||||||
|  |         // eslint-disable-next-line no-unsanitized/method
 | ||||||
|         this.output.insertAdjacentHTML('BeforeEnd', message); |         this.output.insertAdjacentHTML('BeforeEnd', message); | ||||||
|       } else { |       } else { | ||||||
|         this.output.textContent += message; |         this.output.textContent += message; | ||||||
|  | |||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user