Enable the ESLint no-var rule globally

A significant portion of the code-base has now been converted to use `let`/`const`, rather than `var`, hence it should be possible to simply enable the ESLint `no-var` rule globally.
This way we can ensure that new code won't accidentally use `var`, and it also removes the need to manually enable the rule in various folders.

Obviously it makes sense to continue the efforts to replace `var`, but that should probably happen on a file and/or folder basis.

Please note that this patch excludes the following code:
 - The `extensions/` folder, since that seemed easiest for now (and I don't know exactly what the support situation is for the Chromium-extension).

 - The entire `external/` folder is ignored, since most of it's currently excluded from linting.
   For the code that isn't imported from elsewhere (and should be ignored), we should probably (at some point) bring the code up to the same linting/formatting standard as the rest of the code-base.

 - Various files in the `test/` folder are ignored, as necessary, since the way that a lot of this code is loaded will require some care (or perhaps larger re-factoring) when removing `var` usage.

.eslintignore

@@ -7,7 +7,7 @@ external/webL10n/
 external/cmapscompress/
 external/builder/fixtures/
 external/builder/fixtures_esprima/
-external/quickjs/quickjs-eval.js
+external/quickjs/
 src/shared/cffStandardStrings.js
 src/shared/fonts_utils.js
 test/tmp/

.eslintrc

@@ -197,7 +197,7 @@
     "no-useless-computed-key": "error",
     "no-useless-constructor": "error",
     "no-useless-rename": "error",
-    "no-var": "off",
+    "no-var": "error",
     "object-shorthand": ["error", "always", {
       "avoidQuotes": true,
     }],

examples/.eslintrc

@@ -8,9 +8,4 @@
     "pdfjsLib": false,
     "pdfjsViewer": false,
   },
-
-  "rules": {
-    // ECMAScript 6
-    "no-var": "error",
-  },
 }

extensions/chromium/.eslintrc

@@ -17,6 +17,7 @@
 
   "rules": {
     "mozilla/import-globals": "error",
+    "no-var": "off",
     "object-shorthand": "off",
   },
 }

extensions/firefox/.eslintrc

@@ -16,6 +16,7 @@
 
   "rules": {
     // Items different from the mozilla/recommended configuration.
+    "no-var": "off",
 
     // Other rules mozilla/recommended hasn't enabled yet.
     "no-shadow": "error",

external/.eslintrc

@@ -6,4 +6,9 @@
   "env": {
     "node": true,
   },
+
+  "rules": {
+    // ECMAScript 6
+    "no-var": "off",
+  },
 }

gulpfile.js

@@ -13,7 +13,6 @@
  * limitations under the License.
  */
 /* eslint-env node */
-/* eslint no-var: error */
 /* globals target */
 
 "use strict";

src/.eslintrc

@@ -1,10 +0,0 @@
-{
-  "extends": [
-    "../.eslintrc"
-  ],
-
-  "rules": {
-    // ECMAScript 6
-    "no-var": "error",
-  },
-}

src/core/.eslintrc

@@ -4,7 +4,7 @@
   },
 
   "extends": [
-    "../.eslintrc"
+    "../../.eslintrc"
   ],
 
   "env": {

src/shared/.eslintrc

@@ -4,7 +4,7 @@
   },
 
   "extends": [
-    "../.eslintrc"
+    "../../.eslintrc"
   ],
 
   "env": {

systemjs.config.js

@@ -12,6 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+/* eslint-disable no-var */
 
 "use strict";
 

test/add_test.js

@@ -1,3 +1,5 @@
+/* eslint-disable no-var */
+
 const fs = require("fs");
 const crypto = require("crypto");
 const execSync = require("child_process").execSync;

test/chromium/test-telemetry.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+/* eslint-disable no-var */
 
 "use strict";
 

test/downloadutils.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+/* eslint-disable no-var */
 
 "use strict";
 

test/driver.js

@@ -12,6 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+/* eslint-disable no-var */
 /* globals pdfjsLib, pdfjsViewer */
 
 "use strict";

test/font/.eslintrc

@@ -1,10 +0,0 @@
-{
-  "extends": [
-    "../.eslintrc"
-  ],
-
-  "rules": {
-    // ECMAScript 6
-    "no-var": "error",
-  },
-}

test/stats/statcmp.js

@@ -1,3 +1,5 @@
+/* eslint-disable no-var */
+
 "use strict";
 
 var fs = require("fs");

test/test.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+/* eslint-disable no-var */
 
 "use strict";
 

test/testutils.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+/* eslint-disable no-var */
 
 "use strict";
 

test/unit/.eslintrc

@@ -6,8 +6,5 @@
   "rules": {
     // Plugins
     "import/no-unresolved": ["error", { "ignore": ["pdfjs/"] }],
-
-    // ECMAScript 6
-    "no-var": "error",
   },
 }

test/webserver.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+/* eslint-disable no-var */
 
 "use strict";
 

web/.eslintrc

@@ -6,8 +6,5 @@
   "rules": {
     // Plugins
     "import/no-unresolved": ["error", { "ignore": ["pdfjs-lib"]}],
-
-    // ECMAScript 6
-    "no-var": "error",
   },
 }