Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #17596 from nicolo-ribaudo/fix-babel-plugin

Browse Source 
Fix transform of unary expression in Babel plugin
This commit is contained in:
Jonas Jenwald 2024-01-29 12:57:42 +01:00 committed by GitHub
commit 56dabe9390
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 21 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
external/builder/babel-plugin-pdfjs-preprocessor.mjs vendored
View File

@ -92,9 +92,13 @@ function babelPluginPDFJSPreprocessor(babel, ctx) {
} }
}, },
}, },
UnaryExpression(path) { UnaryExpression: {
exit(path) {
const { node } = path; const { node } = path;
if (node.operator === "typeof" && isPDFJSPreprocessor(node.argument)) { if (
node.operator === "typeof" &&
isPDFJSPreprocessor(node.argument)
) {
// typeof PDFJSDev => 'object' // typeof PDFJSDev => 'object'
path.replaceWith(t.stringLiteral("object")); path.replaceWith(t.stringLiteral("object"));
return; return;
@ -104,6 +108,7 @@ function babelPluginPDFJSPreprocessor(babel, ctx) {
path.replaceWith(t.booleanLiteral(!node.argument.value)); path.replaceWith(t.booleanLiteral(!node.argument.value));
} }
}, },
},
LogicalExpression: { LogicalExpression: {
exit(path) { exit(path) {
const { node } = path; const { node } = path;

2
external/builder/fixtures_esprima/evals-expected.js vendored
View File

@ -17,3 +17,5 @@ var i = '0';
var j = { var j = {
i: 1 i: 1
}; };
var k = false;
var l = true;

2
external/builder/fixtures_esprima/evals.js vendored
View File

@ -8,3 +8,5 @@ var g = PDFJSDev.eval('OBJ');
var h = PDFJSDev.json('$ROOT/external/builder/fixtures_esprima/evals.json'); var h = PDFJSDev.json('$ROOT/external/builder/fixtures_esprima/evals.json');
var i = typeof PDFJSDev === 'undefined' ? PDFJSDev.eval('FALSE') : '0'; var i = typeof PDFJSDev === 'undefined' ? PDFJSDev.eval('FALSE') : '0';
var j = typeof PDFJSDev !== 'undefined' ? PDFJSDev.eval('OBJ.obj') : '0'; var j = typeof PDFJSDev !== 'undefined' ? PDFJSDev.eval('OBJ.obj') : '0';
var k = !PDFJSDev.test('TRUE');
var l = !PDFJSDev.test('FALSE');

2
web/firefoxcom.js
View File

@ -400,7 +400,7 @@ class ExternalServices extends BaseExternalServices {
} }
async getNimbusExperimentData() { async getNimbusExperimentData() {
if (typeof PDFJSDev === "undefined" || !PDFJSDev.test("GECKOVIEW")) { if (!PDFJSDev.test("GECKOVIEW")) {
return null; return null;
} }
const nimbusData = await FirefoxCom.requestAsync( const nimbusData = await FirefoxCom.requestAsync(