From 527251d62b1ac99cef12e9eb249a6938ff3ea6f2 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Wed, 11 May 2022 12:32:41 +0200
Subject: [PATCH] Update the `preprocess`-function to avoid adding trailing
 new-lines (issue 14902)

*This is a follow-up to PR 14886, which "broke" this.*

In addition to fixing the issue, using an Array and `join`-ing it at the end may also be a tiny bit more efficient than using a growing string.
---
 external/builder/builder.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/external/builder/builder.js b/external/builder/builder.js
index 8c44ddeb2..e13ad8b27 100644
--- a/external/builder/builder.js
+++ b/external/builder/builder.js
@@ -57,7 +57,7 @@ function preprocess(inFilename, outFilename, defines) {
   }
   const lines = content.split("\n"),
     totalLines = lines.length;
-  let out = "";
+  const out = [];
   let i = 0;
   function readLine() {
     if (i < totalLines) {
@@ -69,7 +69,7 @@ function preprocess(inFilename, outFilename, defines) {
     typeof outFilename === "function"
       ? outFilename
       : function (line) {
-          out += line + "\n";
+          out.push(line);
         };
   function evaluateCondition(code) {
     if (!code || !code.trim()) {
@@ -210,7 +210,7 @@ function preprocess(inFilename, outFilename, defines) {
     );
   }
   if (typeof outFilename !== "function") {
-    fs.writeFileSync(outFilename, out);
+    fs.writeFileSync(outFilename, out.join("\n"));
   }
 }
 exports.preprocess = preprocess;