Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #8116 from Snuffleupagus/download_manager-preprocessor

Browse Source 
Get rid of a couple `eslint-disable` statements in `web/download_manager.js` by instead relying on the preprocessor dead-code removal added in PR 7942
This commit is contained in:
Tim van der Meij 2017-02-28 22:03:47 +01:00 committed by GitHub
commit 522281c01d
1 changed files with 82 additions and 81 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
web/download_manager.js
View File

@ -25,9 +25,11 @@
factory((root.pdfjsWebDownloadManager = {}), root.pdfjsWebPDFJS); factory((root.pdfjsWebDownloadManager = {}), root.pdfjsWebPDFJS);
} }
}(this, function (exports, pdfjsLib) { }(this, function (exports, pdfjsLib) {
if (typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC || CHROME')) { if (typeof PDFJSDev !== 'undefined' && PDFJSDev.test('FIREFOX || MOZCENTRAL')) {
// eslint-disable-next-line no-inner-declarations return;
function download(blobUrl, filename) { }
function download(blobUrl, filename) {
var a = document.createElement('a'); var a = document.createElement('a');
if (a.click) { if (a.click) {
// Use a.click() if available. Otherwise, Chrome might show // Use a.click() if available. Otherwise, Chrome might show
@ -61,11 +63,11 @@ if (typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC || CHROME')) {
} }
window.open(blobUrl, '_parent'); window.open(blobUrl, '_parent');
} }
} }
function DownloadManager() {} // eslint-disable-line no-inner-declarations function DownloadManager() {}
DownloadManager.prototype = { DownloadManager.prototype = {
downloadUrl: function DownloadManager_downloadUrl(url, filename) { downloadUrl: function DownloadManager_downloadUrl(url, filename) {
if (!pdfjsLib.createValidAbsoluteUrl(url, 'http://example.com')) { if (!pdfjsLib.createValidAbsoluteUrl(url, 'http://example.com')) {
return; // restricted/invalid URL return; // restricted/invalid URL
@ -103,8 +105,7 @@ if (typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC || CHROME')) {
var blobUrl = URL.createObjectURL(blob); var blobUrl = URL.createObjectURL(blob);
download(blobUrl, filename); download(blobUrl, filename);
} }
}; };
exports.DownloadManager = DownloadManager; exports.DownloadManager = DownloadManager;
}
})); }));