Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enable the unicorn/prefer-modern-dom-apis ESLint plugin rule

Browse Source 
This rule will help enforce slightly shorter code, and according to MDN both `Element.replaceWith()` and `Element.before()` are available in all browsers that we currently support.

Please find additional information here:
 - https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-modern-dom-apis.md
 - https://developer.mozilla.org/en-US/docs/Web/API/Element/replaceWith
 - https://developer.mozilla.org/en-US/docs/Web/API/Element/before
This commit is contained in:
Jonas Jenwald 2022-06-12 17:19:32 +02:00
parent 0c65926d5b
commit 4d39898823
4 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc
View File

@ -53,6 +53,7 @@
"unicorn/prefer-date-now": "error", "unicorn/prefer-date-now": "error",
"unicorn/prefer-dom-node-append": "error", "unicorn/prefer-dom-node-append": "error",
"unicorn/prefer-dom-node-remove": "error", "unicorn/prefer-dom-node-remove": "error",
"unicorn/prefer-modern-dom-apis": "error",
"unicorn/prefer-string-starts-ends-with": "error", "unicorn/prefer-string-starts-ends-with": "error",
// Possible errors // Possible errors

2
extensions/chromium/contentscript.js
View File

@ -133,7 +133,7 @@ function updateEmbedElement(elem) {
elem.type = "text/html"; elem.type = "text/html";
elem.src = getEmbeddedViewerURL(elem.src); elem.src = getEmbeddedViewerURL(elem.src);
if (parentNode) { if (parentNode) {
parentNode.insertBefore(elem, nextSibling); nextSibling.before(elem);
} }
} }

4
src/display/annotation_layer.js
View File

@ -2559,9 +2559,9 @@ class AnnotationLayer {
if (!firstChild) { if (!firstChild) {
element.append(canvas); element.append(canvas);
} else if (firstChild.nodeName === "CANVAS") { } else if (firstChild.nodeName === "CANVAS") {
element.replaceChild(canvas, firstChild); firstChild.replaceWith(canvas);
} else { } else {
element.insertBefore(canvas, firstChild); firstChild.before(canvas);
} }
} }
annotationCanvasMap.clear(); annotationCanvasMap.clear();

4
web/pdf_page_view.js
View File

@ -627,7 +627,7 @@ class PDFPageView {
if (lastDivBeforeTextDiv) { if (lastDivBeforeTextDiv) {
// The annotation layer needs to stay on top. // The annotation layer needs to stay on top.
div.insertBefore(canvasWrapper, lastDivBeforeTextDiv); lastDivBeforeTextDiv.before(canvasWrapper);
} else { } else {
div.append(canvasWrapper); div.append(canvasWrapper);
} }
@ -640,7 +640,7 @@ class PDFPageView {
textLayerDiv.style.height = canvasWrapper.style.height; textLayerDiv.style.height = canvasWrapper.style.height;
if (lastDivBeforeTextDiv) { if (lastDivBeforeTextDiv) {
// The annotation layer needs to stay on top. // The annotation layer needs to stay on top.
div.insertBefore(textLayerDiv, lastDivBeforeTextDiv); lastDivBeforeTextDiv.before(textLayerDiv);
} else { } else {
div.append(textLayerDiv); div.append(textLayerDiv);
} }