From c7a90e04219ec6177b42f6e5c26c5202ecbbbe23 Mon Sep 17 00:00:00 2001 From: Brendan Dahl Date: Fri, 17 Feb 2012 09:43:50 -0800 Subject: [PATCH 1/3] Fix parse query. --- web/viewer.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/web/viewer.js b/web/viewer.js index 5e94c2241..02f2b6a10 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -620,10 +620,13 @@ var PDFView = { // Helper function to parse query string (e.g. ?param1=value&parm2=...). parseQueryString: function pdfViewParseQueryString(query) { - var params = query.split('&'); - for (var i = 0; i < params.length; i++) { - var param = params[i].split('='); - params[unescape(param[0])] = unescape(param[1]); + var parts = query.split('&'); + var params = []; + for (var i = 0, ii = parts.length; i < parts.length; ++i) { + var param = parts[i].split('='); + var key = param[0]; + var value = param.length > 1 ? param[1] : null; + params[unescape(key)] = unescape(value); } return params; } From 8d3c63ef073a5ecc4c9a62c982c1760865b1070c Mon Sep 17 00:00:00 2001 From: Brendan Dahl Date: Fri, 17 Feb 2012 09:49:17 -0800 Subject: [PATCH 2/3] Use obj instead of array. --- web/viewer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/viewer.js b/web/viewer.js index 02f2b6a10..e8533bd59 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -621,7 +621,7 @@ var PDFView = { // Helper function to parse query string (e.g. ?param1=value&parm2=...). parseQueryString: function pdfViewParseQueryString(query) { var parts = query.split('&'); - var params = []; + var params = {}; for (var i = 0, ii = parts.length; i < parts.length; ++i) { var param = parts[i].split('='); var key = param[0]; From 290aa0ef5d2c8d13adb97a5a8c51b15f345951ab Mon Sep 17 00:00:00 2001 From: Brendan Dahl Date: Fri, 17 Feb 2012 10:00:35 -0800 Subject: [PATCH 3/3] Fix upstream lint error. --- src/stream.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stream.js b/src/stream.js index 91279f7a2..f76a07b4c 100644 --- a/src/stream.js +++ b/src/stream.js @@ -645,7 +645,7 @@ var PredictorStream = (function PredictorStreamClosure() { } } else if (bits === 8) { for (var i = 0; i < colors; ++i) - buffer[pos++] = rawBytes[i]; + buffer[pos++] = rawBytes[i]; for (; i < rowBytes; ++i) { buffer[pos] = buffer[pos - colors] + rawBytes[i]; pos++;