Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a TESTING build option, to enable using non-production/test-only code-paths

Browse Source 
Since the tests (currently) run with the `pdf.worker.js` file built, i.e. with `PRODUCTION = true` set, there's no simple way to add e.g. `assert` calls for both non-production *and* test-only builds without also affecting PRODUCTION builds.
This commit is contained in:
Jonas Jenwald 2018-06-11 17:25:50 +02:00
parent f01e54eae1
commit 4b69bb7fe9
3 changed files with 24 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
gulpfile.js
View File

@ -86,6 +86,7 @@ var AUTOPREFIXER_CONFIG = {
var DEFINES = { var DEFINES = {
PRODUCTION: true, PRODUCTION: true,
TESTING: false,
// The main build targets: // The main build targets:
GENERIC: false, GENERIC: false,
FIREFOX: false, FIREFOX: false,
@ -137,6 +138,7 @@ function createWebpackConfig(defines, output) {
var bundleDefines = builder.merge(defines, { var bundleDefines = builder.merge(defines, {
BUNDLE_VERSION: versionInfo.version, BUNDLE_VERSION: versionInfo.version,
BUNDLE_BUILD: versionInfo.commit, BUNDLE_BUILD: versionInfo.commit,
TESTING: (defines.TESTING || process.env['TESTING'] === 'true'),
}); });
var licenseHeaderLibre = var licenseHeaderLibre =
fs.readFileSync('./src/license_header_libre.js').toString(); fs.readFileSync('./src/license_header_libre.js').toString();
@ -875,6 +877,7 @@ gulp.task('lib', ['buildnumber'], function () {
LIB: true, LIB: true,
BUNDLE_VERSION: versionInfo.version, BUNDLE_VERSION: versionInfo.version,
BUNDLE_BUILD: versionInfo.commit, BUNDLE_BUILD: versionInfo.commit,
TESTING: process.env['TESTING'] === 'true',
}), }),
map: { map: {
'pdfjs-lib': '../pdf', 'pdfjs-lib': '../pdf',
@ -927,34 +930,39 @@ gulp.task('publish', ['generic'], function (done) {
}); });
}); });
gulp.task('test', ['generic', 'components'], function () { gulp.task('testing-pre', function() {
process.env['TESTING'] = 'true';
});
gulp.task('test', ['testing-pre', 'generic', 'components'], function() {
return streamqueue({ objectMode: true, }, return streamqueue({ objectMode: true, },
createTestSource('unit'), createTestSource('browser')); createTestSource('unit'), createTestSource('browser'));
}); });
gulp.task('bottest', ['generic', 'components'], function () { gulp.task('bottest', ['testing-pre', 'generic', 'components'], function() {
return streamqueue({ objectMode: true, }, return streamqueue({ objectMode: true, },
createTestSource('unit'), createTestSource('font'), createTestSource('unit'), createTestSource('font'),
createTestSource('browser (no reftest)')); createTestSource('browser (no reftest)'));
}); });
gulp.task('browsertest', ['generic', 'components'], function () { gulp.task('browsertest', ['testing-pre', 'generic', 'components'], function() {
return createTestSource('browser'); return createTestSource('browser');
}); });
gulp.task('unittest', ['generic', 'components'], function () { gulp.task('unittest', ['testing-pre', 'generic', 'components'], function() {
return createTestSource('unit'); return createTestSource('unit');
}); });
gulp.task('fonttest', function () { gulp.task('fonttest', ['testing-pre'], function() {
return createTestSource('font'); return createTestSource('font');
}); });
gulp.task('makeref', ['generic', 'components'], function (done) { gulp.task('makeref', ['testing-pre', 'generic', 'components'], function(done) {
makeRef(done); makeRef(done);
}); });
gulp.task('botmakeref', ['generic', 'components'], function (done) { gulp.task('botmakeref', ['testing-pre', 'generic', 'components'],
function(done) {
makeRef(done, true); makeRef(done, true);
}); });
@ -994,7 +1002,7 @@ gulp.task('baseline', function (done) {
}); });
}); });
gulp.task('unittestcli', ['lib'], function (done) { gulp.task('unittestcli', ['testing-pre', 'lib'], function(done) {
var args = ['JASMINE_CONFIG_PATH=test/unit/clitests.json']; var args = ['JASMINE_CONFIG_PATH=test/unit/clitests.json'];
var testProcess = spawn('node_modules/.bin/jasmine', args, var testProcess = spawn('node_modules/.bin/jasmine', args,
{ stdio: 'inherit', }); { stdio: 'inherit', });

6
src/core/parser.js
View File

@ -34,8 +34,10 @@ const MAX_ADLER32_LENGTH = 5552;
function computeAdler32(bytes) { function computeAdler32(bytes) {
let bytesLength = bytes.length; let bytesLength = bytes.length;
if (bytesLength >= MAX_ADLER32_LENGTH) { if (typeof PDFJSDev === 'undefined' ||
throw new Error('computeAdler32: The input is too large.'); PDFJSDev.test('!PRODUCTION || TESTING')) {
assert(bytesLength < MAX_ADLER32_LENGTH,
'computeAdler32: Unsupported "bytes" length.');
} }
let a = 1, b = 0; let a = 1, b = 0;
for (let i = 0; i < bytesLength; ++i) { for (let i = 0; i < bytesLength; ++i) {

6
src/core/worker.js
View File

@ -379,8 +379,10 @@ var WorkerMessageHandler = {
let apiVersion = docParams.apiVersion; let apiVersion = docParams.apiVersion;
let workerVersion = let workerVersion =
typeof PDFJSDev !== 'undefined' ? PDFJSDev.eval('BUNDLE_VERSION') : null; typeof PDFJSDev !== 'undefined' ? PDFJSDev.eval('BUNDLE_VERSION') : null;
// The `apiVersion !== null` check is needed to avoid errors during testing. if ((typeof PDFJSDev !== 'undefined' && PDFJSDev.test('TESTING')) &&
if (apiVersion !== null && apiVersion !== workerVersion) { apiVersion === null) {
warn('Ignoring apiVersion/workerVersion check in TESTING builds.');
} else if (apiVersion !== workerVersion) {
throw new Error(`The API version "${apiVersion}" does not match ` + throw new Error(`The API version "${apiVersion}" does not match ` +
`the Worker version "${workerVersion}".`); `the Worker version "${workerVersion}".`);
} }