From 48c64c6c8d2323251c83589b0b59499e9c72c72d Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Mon, 28 Feb 2022 21:24:38 +0100 Subject: [PATCH] Bug 1757527 - Slightly reduce (repeated) message passing overhead when localizing the PDF Viewer --- extensions/firefox/tools/l10n.js | 12 +++++++----- web/firefoxcom.js | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/extensions/firefox/tools/l10n.js b/extensions/firefox/tools/l10n.js index 383764512..7cc43dc8e 100644 --- a/extensions/firefox/tools/l10n.js +++ b/extensions/firefox/tools/l10n.js @@ -2,14 +2,16 @@ // Small subset of the webL10n API by Fabien Cazenave for PDF.js extension. (function (window) { - var gLanguage = ""; - var gExternalLocalizerServices = null; - var gReadyState = "loading"; + let gL10nData = null; + let gLanguage = ""; + let gExternalLocalizerServices = null; + let gReadyState = "loading"; // fetch an l10n objects function getL10nData(key) { - var response = gExternalLocalizerServices.getStrings(key); - var data = JSON.parse(response); + gL10nData ||= gExternalLocalizerServices.getStrings(); + + const data = gL10nData?.[key]; if (!data) { console.warn("[l10n] #" + key + " missing for [" + gLanguage + "]"); } diff --git a/web/firefoxcom.js b/web/firefoxcom.js index 7b3123260..aa9c87654 100644 --- a/web/firefoxcom.js +++ b/web/firefoxcom.js @@ -437,7 +437,7 @@ document.mozL10n.setExternalLocalizerServices({ }, getStrings(key) { - return FirefoxCom.requestSync("getStrings", key); + return FirefoxCom.requestSync("getStrings", null); }, });