Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fail when MD5 of test files fails on bots.

Browse Source
This commit is contained in:
Brendan Dahl 2018-08-03 17:48:47 -07:00
parent 8a4be24645
commit 482ea2af32
2 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gulpfile.js
View File

@ -356,7 +356,7 @@ function getTempFile(prefix, suffix) {
return path; return path;
} }
function createTestSource(testsName) { function createTestSource(testsName, bot) {
var source = stream.Readable({ objectMode: true, }); var source = stream.Readable({ objectMode: true, });
source._read = function () { source._read = function () {
console.log(); console.log();
@ -394,6 +394,9 @@ function createTestSource(testsName) {
return null; return null;
} }
args.push('--browserManifestFile=' + PDF_BROWSERS); args.push('--browserManifestFile=' + PDF_BROWSERS);
if (bot) {
args.push('--strictVerify');
}
var testProcess = spawn('node', args, { cwd: TEST_DIR, stdio: 'inherit', }); var testProcess = spawn('node', args, { cwd: TEST_DIR, stdio: 'inherit', });
testProcess.on('close', function (code) { testProcess.on('close', function (code) {
@ -403,7 +406,7 @@ function createTestSource(testsName) {
return source; return source;
} }
function makeRef(done, noPrompts) { function makeRef(done, bot) {
console.log(); console.log();
console.log('### Creating reference images'); console.log('### Creating reference images');
@ -420,8 +423,8 @@ function makeRef(done, noPrompts) {
} }
var args = ['test.js', '--masterMode']; var args = ['test.js', '--masterMode'];
if (noPrompts) { if (bot) {
args.push('--noPrompts'); args.push('--noPrompts', '--strictVerify');
} }
args.push('--browserManifestFile=' + PDF_BROWSERS); args.push('--browserManifestFile=' + PDF_BROWSERS);
var testProcess = spawn('node', args, { cwd: TEST_DIR, stdio: 'inherit', }); var testProcess = spawn('node', args, { cwd: TEST_DIR, stdio: 'inherit', });
@ -980,8 +983,8 @@ gulp.task('test', ['testing-pre', 'generic', 'components'], function() {
gulp.task('bottest', ['testing-pre', 'generic', 'components'], function() { gulp.task('bottest', ['testing-pre', 'generic', 'components'], function() {
return streamqueue({ objectMode: true, }, return streamqueue({ objectMode: true, },
createTestSource('unit'), createTestSource('font'), createTestSource('unit', true), createTestSource('font', true),
createTestSource('browser (no reftest)')); createTestSource('browser (no reftest)', true));
}); });
gulp.task('browsertest', ['testing-pre', 'generic', 'components'], function() { gulp.task('browsertest', ['testing-pre', 'generic', 'components'], function() {

6
test/test.js
View File

@ -36,7 +36,7 @@ function parseOptions() {
var yargs = require('yargs') var yargs = require('yargs')
.usage('Usage: $0') .usage('Usage: $0')
.boolean(['help', 'masterMode', 'reftest', 'unitTest', 'fontTest', .boolean(['help', 'masterMode', 'reftest', 'unitTest', 'fontTest',
'noPrompts', 'noDownload', 'downloadOnly']) 'noPrompts', 'noDownload', 'downloadOnly', 'strictVerify'])
.string(['manifestFile', 'browser', 'browserManifestFile', .string(['manifestFile', 'browser', 'browserManifestFile',
'port', 'statsFile', 'statsDelay', 'testfilter']) 'port', 'statsFile', 'statsDelay', 'testfilter'])
.alias('browser', 'b').alias('help', 'h').alias('masterMode', 'm') .alias('browser', 'b').alias('help', 'h').alias('masterMode', 'm')
@ -63,6 +63,7 @@ function parseOptions() {
.describe('fontTest', 'Run the font tests.') .describe('fontTest', 'Run the font tests.')
.describe('noDownload', 'Skips test PDFs downloading.') .describe('noDownload', 'Skips test PDFs downloading.')
.describe('downloadOnly', 'Download test PDFs without running the tests.') .describe('downloadOnly', 'Download test PDFs without running the tests.')
.describe('strictVerify', 'Error if verifying the manifest files fails.')
.describe('statsFile', 'The file where to store stats.') .describe('statsFile', 'The file where to store stats.')
.describe('statsDelay', 'The amount of time in milliseconds the browser ' + .describe('statsDelay', 'The amount of time in milliseconds the browser ' +
'should wait before starting stats.') 'should wait before starting stats.')
@ -716,6 +717,9 @@ function ensurePDFsDownloaded(callback) {
'used for testing.'); 'used for testing.');
console.log('Please re-download the files, or adjust the MD5 ' + console.log('Please re-download the files, or adjust the MD5 ' +
'checksum in the manifest for the files listed above.\n'); 'checksum in the manifest for the files listed above.\n');
if (options.strictVerify) {
process.exit(1);
}
} }
callback(); callback();
}); });