Enable the no-typeof-undefined ESLint plugin rule

Please see https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-typeof-undefined.md
This commit is contained in:
Jonas Jenwald 2022-11-27 17:16:46 +01:00
parent 4793a0717f
commit 47dbfc4ade
7 changed files with 8 additions and 9 deletions

View File

@ -61,6 +61,7 @@
"unicorn/prefer-modern-dom-apis": "error",
"unicorn/prefer-regexp-test": "error",
"unicorn/prefer-string-starts-ends-with": "error",
"unicorn/no-typeof-undefined": ["error", { "checkGlobalVariables": false, }],
// Possible errors
"for-direction": "error",

View File

@ -1870,8 +1870,7 @@ class CanvasGraphics {
this.ctx.closePath();
}
stroke(consumePath) {
consumePath = typeof consumePath !== "undefined" ? consumePath : true;
stroke(consumePath = true) {
const ctx = this.ctx;
const strokeColor = this.current.strokeColor;
// For stroke we want to temporarily change the global alpha to the
@ -1904,8 +1903,7 @@ class CanvasGraphics {
this.stroke();
}
fill(consumePath) {
consumePath = typeof consumePath !== "undefined" ? consumePath : true;
fill(consumePath = true) {
const ctx = this.ctx;
const fillColor = this.current.fillColor;
const isPatternFill = this.current.patternFill;

View File

@ -46,7 +46,7 @@ function createHeaders(httpHeaders) {
const headers = new Headers();
for (const property in httpHeaders) {
const value = httpHeaders[property];
if (typeof value === "undefined") {
if (value === undefined) {
continue;
}
headers.append(property, value);

View File

@ -82,7 +82,7 @@ class NetworkManager {
xhr.withCredentials = this.withCredentials;
for (const property in this.httpHeaders) {
const value = this.httpHeaders[property];
if (typeof value === "undefined") {
if (value === undefined) {
continue;
}
xhr.setRequestHeader(property, value);

View File

@ -373,7 +373,7 @@ class PDFNodeStreamRangeReader extends BaseRangeReader {
this._httpHeaders = {};
for (const property in stream.httpHeaders) {
const value = stream.httpHeaders[property];
if (typeof value === "undefined") {
if (value === undefined) {
continue;
}
this._httpHeaders[property] = value;

View File

@ -12,7 +12,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/* eslint-disable no-var */
/* eslint-disable no-var, unicorn/no-typeof-undefined */
"use strict";

View File

@ -35,7 +35,7 @@ const TestReporter = function (browser) {
status,
description,
};
if (typeof error !== "undefined") {
if (error !== undefined) {
message.error = error;
}
send("/submit_task_results", message);