Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change JpegImage._isColorConversionNeeded into a getter, rather than a regular function

Browse Source 
Given how `_isColorConversionNeeded` is used, and that it always returns a boolean value, having it be a getter seems more appropriate.
This commit is contained in:
Jonas Jenwald 2018-09-02 13:06:28 +02:00
parent c94df0fef3
commit 47bf12cbac
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/jpg.js
View File

@ -1024,7 +1024,7 @@ var JpegImage = (function JpegImageClosure() {
return data; return data;
}, },
_isColorConversionNeeded() { get _isColorConversionNeeded() {
if (this.adobe) { if (this.adobe) {
// The adobe transform marker overrides any previous setting. // The adobe transform marker overrides any previous setting.
return !!this.adobe.transformCode; return !!this.adobe.transformCode;
@ -1180,10 +1180,10 @@ var JpegImage = (function JpegImageClosure() {
rgbData[offset++] = grayColor; rgbData[offset++] = grayColor;
} }
return rgbData; return rgbData;
} else if (this.numComponents === 3 && this._isColorConversionNeeded()) { } else if (this.numComponents === 3 && this._isColorConversionNeeded) {
return this._convertYccToRgb(data); return this._convertYccToRgb(data);
} else if (this.numComponents === 4) { } else if (this.numComponents === 4) {
if (this._isColorConversionNeeded()) { if (this._isColorConversionNeeded) {
if (forceRGBoutput) { if (forceRGBoutput) {
return this._convertYcckToRgb(data); return this._convertYcckToRgb(data);
} }