Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix *some* errors reported by the ESLint no-useless-escape rule

Browse Source 
This patch removes unnecessary escape-sequence in (mostly) strings, as a first step, since the ones in regular expressions probably requires more careful testing (just in case).
The only exception is a regular expression in `src/core/annotation.js`, since we should have both unit- and reference-tests for this code *and* given [this information on MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions/Character_Classes#Types):
 > Inside a character set, the dot loses its special meaning and matches a literal dot.

Please find additional details about the ESLint rule at https://eslint.org/docs/rules/no-useless-escape
This commit is contained in:
Jonas Jenwald 2020-10-29 15:40:40 +01:00
parent 7853d9798b
commit 46e94cad17
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/annotation.js
View File

@ -1333,7 +1333,7 @@ class WidgetAnnotation extends Annotation {
// 1.5 * capHeight * fontSize seems to be a good value for lineHeight // 1.5 * capHeight * fontSize seems to be a good value for lineHeight
fontSize = Math.max(1, Math.floor(height / (1.5 * capHeight))); fontSize = Math.max(1, Math.floor(height / (1.5 * capHeight)));
let fontRegex = new RegExp(`/${fontName}\\s+[0-9\.]+\\s+Tf`); let fontRegex = new RegExp(`/${fontName}\\s+[0-9.]+\\s+Tf`);
if (this.data.defaultAppearance.search(fontRegex) === -1) { if (this.data.defaultAppearance.search(fontRegex) === -1) {
// The font size is missing // The font size is missing
fontRegex = new RegExp(`/${fontName}\\s+Tf`); fontRegex = new RegExp(`/${fontName}\\s+Tf`);

4
src/core/evaluator.js
View File

@ -3415,8 +3415,8 @@ class PartialEvaluator {
var baseFontStr = baseFont && baseFont.name; var baseFontStr = baseFont && baseFont.name;
if (fontNameStr !== baseFontStr) { if (fontNameStr !== baseFontStr) {
info( info(
`The FontDescriptor\'s FontName is "${fontNameStr}" but ` + `The FontDescriptor's FontName is "${fontNameStr}" but ` +
`should be the same as the Font\'s BaseFont "${baseFontStr}".` `should be the same as the Font's BaseFont "${baseFontStr}".`
); );
// Workaround for cases where e.g. fontNameStr = 'Arial' and // Workaround for cases where e.g. fontNameStr = 'Arial' and
// baseFontStr = 'Arial,Bold' (needed when no font file is embedded). // baseFontStr = 'Arial,Bold' (needed when no font file is embedded).

4
src/scripting_api/field.js
View File

@ -110,8 +110,8 @@ class Field extends PDFObject {
} catch (error) { } catch (error) {
event.rc = false; event.rc = false;
const value = const value =
`\"${error.toString()}\" for event ` + `"${error.toString()}" for event ` +
`\"${eventName}\" in object ${this._id}.` + `"${eventName}" in object ${this._id}.` +
`\n${error.stack}`; `\n${error.stack}`;
this._send({ command: "error", value }); this._send({ command: "error", value });
} }

2
src/shared/xml_parser.js
View File

@ -408,7 +408,7 @@ class SimpleDOMNode {
if (this.attributes) { if (this.attributes) {
for (const attribute of this.attributes) { for (const attribute of this.attributes) {
buffer.push( buffer.push(
` ${attribute.name}=\"${encodeToXmlString(attribute.value)}\"` ` ${attribute.name}="${encodeToXmlString(attribute.value)}"`
); );
} }
} }