Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #6662 from Snuffleupagus/issue-6661

Browse Source 
Ensure that the `hidden` attribute is always removed from the canvas when rendering is complete (issue 6661)
This commit is contained in:
Yury Delendik 2015-11-19 07:50:45 -06:00
commit 467c6f93b5
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
web/pdf_page_view.js
View File

@ -308,7 +308,11 @@ var PDFPageView = (function PDFPageViewClosure() {
var canvas = document.createElement('canvas'); var canvas = document.createElement('canvas');
canvas.id = 'page' + this.id; canvas.id = 'page' + this.id;
// Keep the canvas hidden until the first draw callback, or until drawing
// is complete when `!this.renderingQueue`, to prevent black flickering.
canvas.setAttribute('hidden', 'hidden'); canvas.setAttribute('hidden', 'hidden');
var isCanvasHidden = true;
canvasWrapper.appendChild(canvas); canvasWrapper.appendChild(canvas);
if (this.annotationLayer && this.annotationLayer.div) { if (this.annotationLayer && this.annotationLayer.div) {
// annotationLayer needs to stay on top // annotationLayer needs to stay on top
@ -316,7 +320,6 @@ var PDFPageView = (function PDFPageViewClosure() {
} else { } else {
div.appendChild(canvasWrapper); div.appendChild(canvasWrapper);
} }
var isCanvasHidden = true;
this.canvas = canvas; this.canvas = canvas;
//#if MOZCENTRAL || FIREFOX || GENERIC //#if MOZCENTRAL || FIREFOX || GENERIC
@ -401,6 +404,11 @@ var PDFPageView = (function PDFPageViewClosure() {
self.renderingState = RenderingStates.FINISHED; self.renderingState = RenderingStates.FINISHED;
if (isCanvasHidden) {
self.canvas.removeAttribute('hidden');
isCanvasHidden = false;
}
if (self.loadingIconDiv) { if (self.loadingIconDiv) {
div.removeChild(self.loadingIconDiv); div.removeChild(self.loadingIconDiv);
delete self.loadingIconDiv; delete self.loadingIconDiv;