From 433397f87787777a2964ddd63f65863378229397 Mon Sep 17 00:00:00 2001 From: Jonas Date: Thu, 5 Sep 2013 00:42:36 +0200 Subject: [PATCH] Simplify getVisiblePages() in presentation mode --- web/viewer.js | 27 ++++++++------------------- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/web/viewer.js b/web/viewer.js index 843bd2625..c3cae56ea 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -1276,16 +1276,8 @@ var PDFView = { }, getVisiblePages: function pdfViewGetVisiblePages() { - if (!this.isPresentationMode) { - return this.getVisibleElements(this.container, this.pages, true); - } else { - // The algorithm in getVisibleElements is broken in presentation mode. - var visible = [], page = this.page; - var currentPage = this.pages[page - 1]; - visible.push({ id: currentPage.id, view: currentPage }); - - return { first: currentPage, last: currentPage, views: visible}; - } + return this.getVisibleElements(this.container, this.pages, + !this.isPresentationMode); }, getVisibleThumbs: function pdfViewGetVisibleThumbs() { @@ -1780,14 +1772,13 @@ var PageView = function pageView(container, id, scale, }; this.scrollIntoView = function pageViewScrollIntoView(dest) { + if (PDFView.isPresentationMode) { // Avoid breaking presentation mode. + dest = null; + } if (!dest) { scrollIntoView(div); return; } - if (PDFView.isPresentationMode) { // Avoid breaking presentation mode. - PDFView.page = id; - return; - } var x = 0, y = 0; var width = 0, height = 0, widthScale, heightScale; @@ -2423,11 +2414,9 @@ function updateViewarea() { currentId = visiblePages[0].id; } - if (!PDFView.isPresentationMode) { - updateViewarea.inProgress = true; // used in "set page" - PDFView.page = currentId; - updateViewarea.inProgress = false; - } + updateViewarea.inProgress = true; // used in "set page" + PDFView.page = currentId; + updateViewarea.inProgress = false; var currentScale = PDFView.currentScale; var currentScaleValue = PDFView.currentScaleValue;