Merge pull request #17242 from Snuffleupagus/fieldObjects-async-fetch

Ensure that `fieldObjects` and `#collectFieldObjects` handles References correctly

src/core/document.js

@@ -1711,13 +1711,18 @@ class PDFDocument {
       : clearGlobalCaches();
   }
 
-  #collectFieldObjects(name, fieldRef, promises, annotationGlobals) {
+  async #collectFieldObjects(name, fieldRef, promises, annotationGlobals) {
-    const field = this.xref.fetchIfRef(fieldRef);
+    const { xref } = this;
+
+    if (!(fieldRef instanceof Ref)) {
+      return;
+    }
+    const field = await xref.fetchAsync(fieldRef);
     if (!(field instanceof Dict)) {
       return;
     }
     if (field.has("T")) {
-      const partName = stringToPDFString(field.get("T"));
+      const partName = stringToPDFString(await field.getAsync("T"));
       name = name === "" ? partName : `${name}.${partName}`;
     }
 
@@ -1726,10 +1731,10 @@ class PDFDocument {
     }
     promises.get(name).push(
       AnnotationFactory.create(
-        this.xref,
+        xref,
         fieldRef,
         annotationGlobals,
-        this._localIdFactory,
+        /* idFactory = */ null,
         /* collectFields */ true,
         /* pageRef */ null
       )
@@ -1740,10 +1745,13 @@ class PDFDocument {
         })
     );
 
-    const kids = field.get("Kids");
+    if (!field.has("Kids")) {
+      return;
+    }
+    const kids = await field.getAsync("Kids");
     if (Array.isArray(kids)) {
       for (const kid of kids) {
-        this.#collectFieldObjects(name, kid, promises, annotationGlobals);
+        await this.#collectFieldObjects(name, kid, promises, annotationGlobals);
       }
     }
   }
@@ -1753,17 +1761,18 @@ class PDFDocument {
       return shadow(this, "fieldObjects", Promise.resolve(null));
     }
 
-    const promise = this.pdfManager
+    const promise = Promise.all([
-      .ensureDoc("annotationGlobals")
+      this.pdfManager.ensureDoc("annotationGlobals"),
-      .then(async annotationGlobals => {
+      this.pdfManager.ensureCatalog("acroForm"),
+    ]).then(async ([annotationGlobals, acroForm]) => {
       if (!annotationGlobals) {
         return null;
       }
 
       const allFields = Object.create(null);
       const fieldPromises = new Map();
-        for (const fieldRef of this.catalog.acroForm.get("Fields")) {
+      for (const fieldRef of await acroForm.getAsync("Fields")) {
-          this.#collectFieldObjects(
+        await this.#collectFieldObjects(
           "",
           fieldRef,
           fieldPromises,