Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused anchor links placed before every page

Browse Source 
In old versions of the viewer, anchor links were used to be able to scroll a page into view. Since we for quite some time have had a `scrollIntoView` function which handles this, the anchor links are no longer necessary and I believe that they can be removed. Doing so will reduce the total number of DOM elements in the viewer.

For most documents this patch will probably not make much of a difference performance wise, but for very long (1000+ pages) documents this could help performance especially on lower powered hardware.
This commit is contained in:
Jonas Jenwald 2014-12-27 13:06:23 +01:00
parent e93cf5ca97
commit 42a00394b0
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/pdf_page_view.js
View File

@ -75,9 +75,6 @@ var PDFPageView = (function PDFPageViewClosure() {
this.annotationLayer = null; this.annotationLayer = null;
var anchor = document.createElement('a');
anchor.name = '' + this.id;
var div = document.createElement('div'); var div = document.createElement('div');
div.id = 'pageContainer' + this.id; div.id = 'pageContainer' + this.id;
div.className = 'page'; div.className = 'page';
@ -86,7 +83,6 @@ var PDFPageView = (function PDFPageViewClosure() {
this.el = div; // TODO replace 'el' property usage this.el = div; // TODO replace 'el' property usage
this.div = div; this.div = div;
container.appendChild(anchor);
container.appendChild(div); container.appendChild(div);
} }