Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #15287 from calixteman/inserthtml

Browse Source 
[Editor] Remove use of innerHtml
This commit is contained in:
Jonas Jenwald 2022-08-07 14:37:39 +02:00 committed by GitHub
commit 40f9f7e909
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/display/editor/freetext.js
View File

@ -40,8 +40,6 @@ class FreeTextEditor extends AnnotationEditor {
#content = ""; #content = "";
#contentHTML = "";
#hasAlreadyBeenCommitted = false; #hasAlreadyBeenCommitted = false;
#fontSize; #fontSize;
@ -333,7 +331,6 @@ class FreeTextEditor extends AnnotationEditor {
} }
this.disableEditMode(); this.disableEditMode();
this.#contentHTML = this.editorDiv.innerHTML;
this.#content = this.#extractText().trimEnd(); this.#content = this.#extractText().trimEnd();
this.#setEditorDimensions(); this.#setEditorDimensions();
@ -445,8 +442,15 @@ class FreeTextEditor extends AnnotationEditor {
this.width * parentWidth, this.width * parentWidth,
this.height * parentHeight this.height * parentHeight
); );
// eslint-disable-next-line no-unsanitized/property
this.editorDiv.innerHTML = this.#contentHTML; for (const line of this.#content.split("\n")) {
const div = document.createElement("div");
div.append(
line ? document.createTextNode(line) : document.createElement("br")
);
this.editorDiv.append(div);
}
this.div.draggable = true; this.div.draggable = true;
this.editorDiv.contentEditable = false; this.editorDiv.contentEditable = false;
} else { } else {
@ -468,10 +472,6 @@ class FreeTextEditor extends AnnotationEditor {
editor.#fontSize = data.fontSize; editor.#fontSize = data.fontSize;
editor.#color = Util.makeHexColor(...data.color); editor.#color = Util.makeHexColor(...data.color);
editor.#content = data.value; editor.#content = data.value;
editor.#contentHTML = data.value
.split("\n")
.map(line => `<div>${line}</div>`)
.join("");
return editor; return editor;
} }