From 07662cf0350dc8aa6df9abce2f1688ff30ce79ec Mon Sep 17 00:00:00 2001 From: Kalervo Kujala Date: Sun, 11 Sep 2011 22:54:00 +0300 Subject: [PATCH 1/4] fix jslint warnings jslint revealed unused and misspelled variable names. Also some code was refactored to be more simple. --- pdf.js | 120 +++++++++++++++++++++++++++------------------------------ 1 file changed, 57 insertions(+), 63 deletions(-) diff --git a/pdf.js b/pdf.js index 3e8249524..ccd90951d 100644 --- a/pdf.js +++ b/pdf.js @@ -710,9 +710,9 @@ var PredictorStream = (function() { var bits = this.bits = params.get('BitsPerComponent') || 8; var columns = this.columns = params.get('Columns') || 1; - var pixBytes = this.pixBytes = (colors * bits + 7) >> 3; + this.pixBytes = (colors * bits + 7) >> 3; // add an extra pixByte to represent the pixel left of column 0 - var rowBytes = this.rowBytes = (columns * colors * bits + 7) >> 3; + this.rowBytes = (columns * colors * bits + 7) >> 3; DecodeStream.call(this); return this; @@ -722,7 +722,6 @@ var PredictorStream = (function() { constructor.prototype.readBlockTiff = function() { var rowBytes = this.rowBytes; - var pixBytes = this.pixBytes; var bufferLength = this.bufferLength; var buffer = this.ensureBuffer(bufferLength + rowBytes); @@ -733,16 +732,18 @@ var PredictorStream = (function() { var rawBytes = this.stream.getBytes(rowBytes); + var inbuf = 0, outbuf = 0; + var inbits = 0, outbits = 0; + if (bits === 1) { - var inbuf = 0; for (var i = 0; i < rowBytes; ++i) { var c = rawBytes[i]; - inBuf = (inBuf << 8) | c; + inbuf = (inbuf << 8) | c; // bitwise addition is exclusive or - // first shift inBuf and then add - currentRow[i] = (c ^ (inBuf >> colors)) & 0xFF; - // truncate inBuf (assumes colors < 16) - inBuf &= 0xFFFF; + // first shift inbuf and then add + currentRow[i] = (c ^ (inbuf >> colors)) & 0xFF; + // truncate inbuf (assumes colors < 16) + inbuf &= 0xFFFF; } } else if (bits === 8) { for (var i = 0; i < colors; ++i) @@ -752,8 +753,6 @@ var PredictorStream = (function() { } else { var compArray = new Uint8Array(colors + 1); var bitMask = (1 << bits) - 1; - var inbuf = 0, outbut = 0; - var inbits = 0, outbits = 0; var j = 0, k = 0; var columns = this.columns; for (var i = 0; i < columns; ++i) { @@ -1015,11 +1014,11 @@ var Ascii85Stream = (function() { return; } - var bufferLength = this.bufferLength; + var bufferLength = this.bufferLength, buffer; // special code for z if (c == zCode) { - var buffer = this.ensureBuffer(bufferLength + 4); + buffer = this.ensureBuffer(bufferLength + 4); for (var i = 0; i < 4; ++i) buffer[bufferLength + i] = 0; this.bufferLength += 4; @@ -1036,7 +1035,7 @@ var Ascii85Stream = (function() { if (!c || c == tildaCode) break; } - var buffer = this.ensureBuffer(bufferLength + i - 1); + buffer = this.ensureBuffer(bufferLength + i - 1); this.bufferLength += i - 1; // partial ending; @@ -1874,7 +1873,7 @@ var CCITTFaxStream = (function() { for (var i = 0; i < 4; ++i) { code1 = this.lookBits(12); if (code1 != 1) - warning('bad rtc code'); + warn('bad rtc code: ' + code1); this.eatBits(12); if (this.encoding > 0) { this.lookBits(1); @@ -2013,7 +2012,7 @@ var CCITTFaxStream = (function() { } } for (var n = 11; n <= 12; ++n) { - code == this.lookBits(n); + code = this.lookBits(n); if (code == EOF) return 1; if (n < 12) @@ -2437,11 +2436,6 @@ var Lexer = (function() { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 // fx ]; - var MIN_INT = (1 << 31) | 0; - var MAX_INT = (MIN_INT - 1) | 0; - var MIN_UINT = 0; - var MAX_UINT = ((1 << 30) * 4) - 1; - function ToHexDigit(ch) { if (ch >= '0' && ch <= '9') return ch.charCodeAt(0) - 48; @@ -3107,7 +3101,6 @@ var XRef = (function() { }, readXRefStream: function readXRefStream(stream) { var streamParameters = stream.parameters; - var length = streamParameters.get('Length'); var byteWidths = streamParameters.get('W'); var range = streamParameters.get('Index'); if (!range) @@ -3356,7 +3349,7 @@ var Page = (function() { } return shadow(this, 'rotate', rotate); }, - startRendering: function(canvasCtx, continuation, onerror) { + startRendering: function(canvasCtx, continuation) { var self = this; var stats = self.stats; stats.compile = stats.fonts = stats.render = 0; @@ -3754,8 +3747,6 @@ var PDFDoc = (function() { return shadow(this, 'numPages', num); }, getPage: function(n) { - var linearization = this.linearization; - // assert(!linearization, "linearized page access not implemented"); return this.catalog.getPage(n); } }; @@ -4141,7 +4132,7 @@ var PartialEvaluator = (function() { }; constructor.prototype = { - eval: function(stream, xref, resources, fonts, images) { + evaluate: function(stream, xref, resources, fonts, images) { resources = xref.fetchIfRef(resources) || new Dict(); var xobjs = xref.fetchIfRef(resources.get('XObject')) || new Dict(); var patterns = xref.fetchIfRef(resources.get('Pattern')) || new Dict(); @@ -4165,8 +4156,9 @@ var PartialEvaluator = (function() { var dict = IsStream(pattern) ? pattern.dict : pattern; var typeNum = dict.get('PatternType'); if (typeNum == 1) { - patternName.code = this.eval(pattern, xref, - dict.get('Resources'), fonts); + patternName.code = this.evaluate(pattern, xref, + dict.get('Resources'), + fonts); } } } @@ -4185,8 +4177,9 @@ var PartialEvaluator = (function() { ); if ('Form' == type.name) { - args[0].code = this.eval(xobj, xref, xobj.dict.get('Resources'), - fonts, images); + args[0].code = this.evaluate(xobj, xref, + xobj.dict.get('Resources'), fonts, + images); } if (xobj instanceof JpegStream) images.bind(xobj); // monitoring image load @@ -4224,7 +4217,7 @@ var PartialEvaluator = (function() { }, extractEncoding: function(dict, xref, properties) { - var type = properties.type; + var type = properties.type, encoding; if (properties.composite) { if (type == 'CIDFontType2') { var defaultWidth = xref.fetchIfRef(dict.get('DW')) || 1000; @@ -4261,7 +4254,7 @@ var PartialEvaluator = (function() { var glyphsData = glyphsStream.getBytes(0); // Glyph ids are big-endian 2-byte values - var encoding = properties.encoding; + encoding = properties.encoding; // Set encoding 0 to later verify the font has an encoding encoding[0] = { unicode: 0, width: 0 }; @@ -4278,7 +4271,7 @@ var PartialEvaluator = (function() { }; } } else if (type == 'CIDFontType0') { - var encoding = xref.fetchIfRef(dict.get('Encoding')); + encoding = xref.fetchIfRef(dict.get('Encoding')); if (IsName(encoding)) { // Encoding is a predefined CMap if (encoding.name == 'Identity-H') { @@ -4299,7 +4292,7 @@ var PartialEvaluator = (function() { var map = properties.encoding; var baseEncoding = null; if (dict.has('Encoding')) { - var encoding = xref.fetchIfRef(dict.get('Encoding')); + encoding = xref.fetchIfRef(dict.get('Encoding')); if (IsDict(encoding)) { var baseName = encoding.get('BaseEncoding'); if (baseName) @@ -4683,7 +4676,7 @@ var CanvasGraphics = (function() { compile: function(stream, xref, resources, fonts, images) { var pe = new PartialEvaluator(); - return pe.eval(stream, xref, resources, fonts, images); + return pe.evaluate(stream, xref, resources, fonts, images); }, execute: function(code, xref, resources) { @@ -4722,13 +4715,13 @@ var CanvasGraphics = (function() { this.ctx.mozDashOffset = dashPhase; }, setRenderingIntent: function(intent) { - TODO('set rendering intent'); + TODO('set rendering intent: ' + intent); }, setFlatness: function(flatness) { - TODO('set flatness'); + TODO('set flatness: ' + flatness); }, setGState: function(dictName) { - TODO('set graphics state from dict'); + TODO('set graphics state from dict: ' + dictName); }, save: function() { this.ctx.save(); @@ -4923,10 +4916,10 @@ var CanvasGraphics = (function() { } }, setTextRenderingMode: function(mode) { - TODO('text rendering mode'); + TODO('text rendering mode: ' + mode); }, setTextRise: function(rise) { - TODO('text rise'); + TODO('text rise: ' + rise); }, moveText: function(x, y) { this.current.x = this.current.lineX += x; @@ -5028,10 +5021,13 @@ var CanvasGraphics = (function() { // Type3 fonts setCharWidth: function(xWidth, yWidth) { - TODO("type 3 fonts ('d0' operator)"); + TODO('type 3 fonts ("d0" operator) xWidth: ' + xWidth + ' yWidth: ' + + yWidth); }, setCharWidthAndBounds: function(xWidth, yWidth, llx, lly, urx, ury) { - TODO("type 3 fonts ('d1' operator)"); + TODO('type 3 fonts ("d1" operator) xWidth: ' + xWidth + ' yWidth: ' + + yWidth + ' llx: ' + llx + ' lly: ' + lly + ' urx: ' + urx + + ' ury ' + ury); }, // Color @@ -5430,7 +5426,6 @@ var ColorSpace = (function() { var lookup = xref.fetchIfRef(cs[3]); return new IndexedCS(base, hiVal, lookup); case 'Separation': - var name = cs[1]; var alt = ColorSpace.parse(cs[2], xref, res); var tintFn = new PDFFunction(xref, xref.fetchIfRef(cs[3])); return new SeparationCS(alt, tintFn); @@ -5468,12 +5463,12 @@ var SeparationCS = (function() { var base = this.base; var scale = 1 / ((1 << bits) - 1); - var length = 3 * input.length; + var length = input.length; var pos = 0; var numComps = base.numComps; - var baseBuf = new Uint8Array(numComps * input.length); - for (var i = 0, ii = input.length; i < ii; ++i) { + var baseBuf = new Uint8Array(numComps * length); + for (var i = 0; i < length; ++i) { var scaled = input[i] * scale; var tinted = tintFn.func([scaled]); for (var j = 0; j < numComps; ++j) @@ -5779,8 +5774,6 @@ var DummyShading = (function() { var RadialAxialShading = (function() { function constructor(dict, matrix, xref, res, ctx) { this.matrix = matrix; - var bbox = dict.get('BBox'); - var background = dict.get('Background'); this.coordsArr = dict.get('Coords'); this.shadingType = dict.get('ShadingType'); this.type = 'Pattern'; @@ -5838,15 +5831,17 @@ var RadialAxialShading = (function() { getPattern: function() { var coordsArr = this.coordsArr; var type = this.shadingType; + var p0, p1, r0, r1; if (type == 2) { - var p0 = [coordsArr[0], coordsArr[1]]; - var p1 = [coordsArr[2], coordsArr[3]]; + p0 = [coordsArr[0], coordsArr[1]]; + p1 = [coordsArr[2], coordsArr[3]]; } else if (type == 3) { - var p0 = [coordsArr[0], coordsArr[1]]; - var p1 = [coordsArr[3], coordsArr[4]]; - var r0 = coordsArr[2], r1 = coordsArr[5]; + p0 = [coordsArr[0], coordsArr[1]]; + p1 = [coordsArr[3], coordsArr[4]]; + r0 = coordsArr[2]; + r1 = coordsArr[5]; } else { - error(); + error('getPattern type unknown: ' + type); } var matrix = this.matrix; @@ -5869,11 +5864,11 @@ var RadialAxialShading = (function() { p1 = Util.applyTransform(p1, userMatrix); } - var colorStops = this.colorStops; + var colorStops = this.colorStops, grad; if (type == 2) - var grad = ctx.createLinearGradient(p0[0], p0[1], p1[0], p1[1]); + grad = ctx.createLinearGradient(p0[0], p0[1], p1[0], p1[1]); else if (type == 3) - var grad = ctx.createRadialGradient(p0[0], p0[1], r0, p1[0], p1[1], r1); + grad = ctx.createRadialGradient(p0[0], p0[1], r0, p1[0], p1[1], r1); for (var i = 0, ii = colorStops.length; i < ii; ++i) { var c = colorStops[i]; @@ -6064,6 +6059,7 @@ var PDFImage = (function() { var bufferPos = 0; var output = bpc <= 8 ? new Uint8Array(length) : bpc <= 16 ? new Uint16Array(length) : new Uint32Array(length); + var rowComps = width * numComps; if (bpc == 1) { var valueZero = 0, valueOne = 1; @@ -6071,7 +6067,6 @@ var PDFImage = (function() { valueZero = decodeMap[0] ? 1 : 0; valueOne = decodeMap[1] ? 1 : 0; } - var rowComps = width * numComps; var mask = 0; var buf = 0; @@ -6093,8 +6088,7 @@ var PDFImage = (function() { } else { if (decodeMap != null) TODO('interpolate component values'); - var rowComps = width * numComps; - var bits, buf; + var bits = 0, buf = 0; for (var i = 0, ii = length; i < ii; ++i) { if (i % rowComps == 0) { buf = 0; @@ -6299,14 +6293,14 @@ var PDFFunction = (function() { floor *= outputSize; ceil *= outputSize; - var output = []; + var output = [], v = 0; for (var i = 0; i < outputSize; ++i) { if (ceil == floor) { - var v = samples[ceil + i]; + v = samples[ceil + i]; } else { var low = samples[floor + i]; var high = samples[ceil + i]; - var v = low * scale + high * (1 - scale); + v = low * scale + high * (1 - scale); } var i2 = i * 2; From 0dc0dd4c970778cd8eb73142bd10b21084e535ce Mon Sep 17 00:00:00 2001 From: Kalervo Kujala Date: Sun, 11 Sep 2011 23:04:17 +0300 Subject: [PATCH 2/4] fix jslint warnings in fonts.js --- fonts.js | 43 +++++++++++++++++++++---------------------- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/fonts.js b/fonts.js index cc353c03b..3deb09825 100755 --- a/fonts.js +++ b/fonts.js @@ -1056,7 +1056,7 @@ var Font = (function Font() { // Ensure the [h/v]mtx tables contains the advance width and // sidebearings information for numGlyphs in the maxp table - font.pos = (font.start ? font.start : 0) + maxp.offset; + font.pos = (font.start || 0) + maxp.offset; var version = int16(font.getBytes(4)); var numGlyphs = int16(font.getBytes(2)); @@ -1165,7 +1165,7 @@ var Font = (function Font() { return false; } return true; - }; + } // The offsets object holds at the same time a representation of where // to write the table entry information about a table and another offset @@ -1357,7 +1357,7 @@ var Font = (function Font() { } // Enter the translated string into the cache - return charsCache[chars] = str; + return (charsCache[chars] = str); } }; @@ -1390,7 +1390,7 @@ var Type1Parser = function() { r = ((value + r) * c1 + c2) & ((1 << 16) - 1); } return decryptedString.slice(discardNumber); - }; + } /* * CharStrings are encoded following the the CharString Encoding sequence @@ -1593,7 +1593,7 @@ var Type1Parser = function() { } return { charstring: charstring, width: width, lsb: lsb }; - }; + } /* * Returns an object containing a Subrs array and a CharStrings @@ -1613,7 +1613,7 @@ var Type1Parser = function() { for (var i = 0; i < array.length; i++) array[i] = parseFloat(array[i] || 0); return array; - }; + } function readNumber(str, index) { while (str[index] == ' ') @@ -1626,11 +1626,11 @@ var Type1Parser = function() { count++; return parseFloat(str.substr(start, count) || 0); - }; + } function isSeparator(c) { return c == ' ' || c == '\n' || c == '\x0d'; - }; + } this.extractFontProgram = function t1_extractFontProgram(stream) { var eexec = decrypt(stream, kEexecEncryptionKey, 4); @@ -1755,7 +1755,7 @@ var Type1Parser = function() { } return program; - }, + }; this.extractFontHeader = function t1_extractFontHeader(stream, properties) { var headerString = ''; @@ -2153,7 +2153,7 @@ CFF.prototype = { 'globalSubrs': this.createCFFIndexHeader([]), 'charset': (function charset(self) { - var charset = '\x00'; // Encoding + var charsetString = '\x00'; // Encoding var count = glyphs.length; for (var i = 0; i < count; i++) { @@ -2165,9 +2165,9 @@ CFF.prototype = { if (index == -1) index = 0; - charset += String.fromCharCode(index >> 8, index & 0xff); + charsetString += String.fromCharCode(index >> 8, index & 0xff); } - return charset; + return charsetString; })(this), 'charstrings': this.createCFFIndexHeader([[0x8B, 0x0E]].concat(glyphs), @@ -2234,7 +2234,7 @@ var Type2CFF = (function() { this.properties = properties; this.data = this.parse(); - }; + } constructor.prototype = { parse: function cff_parse() { @@ -2457,7 +2457,7 @@ var Type2CFF = (function() { case 21: dict['nominalWidthX'] = value[0]; default: - TODO('interpret top dict key'); + TODO('interpret top dict key: ' + key); } } return dict; @@ -2569,7 +2569,7 @@ var Type2CFF = (function() { error('Incorrect byte'); } return -1; - }; + } function parseFloatOperand() { var str = ''; @@ -2591,7 +2591,7 @@ var Type2CFF = (function() { str += lookup[b2]; } return parseFloat(str); - }; + } var operands = []; var entries = []; @@ -2617,15 +2617,14 @@ var Type2CFF = (function() { parseIndex: function cff_parseIndex(pos) { var bytes = this.bytes; var count = bytes[pos++] << 8 | bytes[pos++]; - if (count == 0) { - var offsets = []; - var end = pos; - } else { + var offsets = []; + var end = pos; + + if (count != 0) { var offsetSize = bytes[pos++]; // add 1 for offset to determine size of last object var startPos = pos + ((count + 1) * offsetSize) - 1; - var offsets = []; for (var i = 0, ii = count + 1; i < ii; ++i) { var offset = 0; for (var j = 0; j < offsetSize; ++j) { @@ -2634,7 +2633,7 @@ var Type2CFF = (function() { } offsets.push(startPos + offset); } - var end = offsets[count]; + end = offsets[count]; } return { From 8e5a8fb49fb0faabc97ed5877a1df4bde3406dc0 Mon Sep 17 00:00:00 2001 From: Kalervo Kujala Date: Mon, 12 Sep 2011 20:37:33 +0300 Subject: [PATCH 3/4] Fix Mode comment lines. --- crypto.js | 2 +- fonts.js | 2 +- glyphlist.js | 2 +- metrics.js | 3 +++ test/driver.js | 2 +- utils/cffStandardStrings.js | 2 +- utils/fonts_utils.js | 2 +- web/compatibility.js | 2 +- web/viewer.js | 2 +- worker/canvas.js | 2 +- worker/client.js | 2 +- worker/console.js | 2 +- worker/font.js | 2 +- worker/pdf.js | 2 +- 14 files changed, 16 insertions(+), 13 deletions(-) diff --git a/crypto.js b/crypto.js index bfffa1f44..a91f9e41d 100644 --- a/crypto.js +++ b/crypto.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ 'use strict'; diff --git a/fonts.js b/fonts.js index 3deb09825..d0d42a941 100755 --- a/fonts.js +++ b/fonts.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ 'use strict'; diff --git a/glyphlist.js b/glyphlist.js index 9be0e8d5a..5691f8546 100644 --- a/glyphlist.js +++ b/glyphlist.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ 'use strict'; diff --git a/metrics.js b/metrics.js index 973d9543a..9cb8eb0e6 100644 --- a/metrics.js +++ b/metrics.js @@ -1,3 +1,6 @@ +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ +/* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ + var Metrics = { 'Courier': 600, 'Courier-Bold': 600, diff --git a/test/driver.js b/test/driver.js index 265de0852..f3e45a53d 100644 --- a/test/driver.js +++ b/test/driver.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ /* diff --git a/utils/cffStandardStrings.js b/utils/cffStandardStrings.js index 09c408ee7..326f298b0 100644 --- a/utils/cffStandardStrings.js +++ b/utils/cffStandardStrings.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ 'use strict'; diff --git a/utils/fonts_utils.js b/utils/fonts_utils.js index 7665906a1..4826a09a1 100644 --- a/utils/fonts_utils.js +++ b/utils/fonts_utils.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ 'use strict'; diff --git a/web/compatibility.js b/web/compatibility.js index e9a769163..63ebecb63 100755 --- a/web/compatibility.js +++ b/web/compatibility.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ // Checking if the typed arrays are supported diff --git a/web/viewer.js b/web/viewer.js index 5752cf84e..d7c9d6b66 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ 'use strict'; diff --git a/worker/canvas.js b/worker/canvas.js index c2a9f4763..5a9237d9a 100644 --- a/worker/canvas.js +++ b/worker/canvas.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ 'use strict'; diff --git a/worker/client.js b/worker/client.js index a00eab59e..a20a4179f 100644 --- a/worker/client.js +++ b/worker/client.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ 'use strict'; diff --git a/worker/console.js b/worker/console.js index 29f511407..fc49583a6 100644 --- a/worker/console.js +++ b/worker/console.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ 'use strict'; diff --git a/worker/font.js b/worker/font.js index 32e22198c..549b73101 100644 --- a/worker/font.js +++ b/worker/font.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ 'use strict'; diff --git a/worker/pdf.js b/worker/pdf.js index 0d5008d80..8cb6342db 100644 --- a/worker/pdf.js +++ b/worker/pdf.js @@ -1,4 +1,4 @@ -/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- / +/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */ 'use strict'; From b5412c13d88d376bb0c0d98a4fb6d8b9550782f6 Mon Sep 17 00:00:00 2001 From: Kalervo Kujala Date: Mon, 12 Sep 2011 20:42:55 +0300 Subject: [PATCH 4/4] Fix gjslint warnings. --- fonts.js | 7 ++++--- pdf.js | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/fonts.js b/fonts.js index d0d42a941..9ba1d876e 100755 --- a/fonts.js +++ b/fonts.js @@ -434,7 +434,7 @@ var Font = (function Font() { // Use 'name' instead of 'fontName' here because the original // name ArialBlack for example will be replaced by Helvetica. - this.black = (name.search(/Black/g) != -1) + this.black = (name.search(/Black/g) != -1); this.loadedName = fontName.split('-')[0]; this.loading = false; @@ -986,7 +986,7 @@ var Font = (function Font() { font.pos = (font.start ? font.start : 0) + header.offset; font.pos += header.length - 2; var numOfMetrics = int16(font.getBytes(2)); - + var numOfSidebearings = numGlyphs - numOfMetrics; var numMissing = numOfSidebearings - ((hmtx.length - numOfMetrics * 4) >> 1); @@ -1807,7 +1807,8 @@ var Type1Parser = function() { if ('undefined' == typeof(properties.differences[index])) { var mapping = properties.encoding[index] || {}; mapping.unicode = GlyphsUnicode[glyph] || index; - properties.glyphs[glyph] = properties.encoding[index] = mapping; + properties.glyphs[glyph] = properties.encoding[index] = + mapping; } getToken(); // read the in 'put' } diff --git a/pdf.js b/pdf.js index ccd90951d..939d9e21c 100644 --- a/pdf.js +++ b/pdf.js @@ -876,8 +876,8 @@ var JpegStream = (function() { function fixYcckImage(bytes) { // Inserting 'EMBED' marker after JPEG signature - var embedMarker = new Uint8Array([0xFF, 0xEC, 0, 8, - 0x45, 0x4D, 0x42, 0x45, 0x44, 0]); + var embedMarker = new Uint8Array([0xFF, 0xEC, 0, 8, 0x45, 0x4D, 0x42, 0x45, + 0x44, 0]); var newBytes = new Uint8Array(bytes.length + embedMarker.length); newBytes.set(bytes, embedMarker.length); // copy JPEG header