Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Tweak adjustType1ToUnicode for fonts with a predefined *named* encoding (bug 1811668, PR 14050 follow-up)

Browse Source 
*Please note:* I cannot reproduce the problem reported in bug 1811668, regarding the context menu, and in any case it's not clear that that part is even a PDF Viewer bug.

Looking at bug 1811668 I couldn't help but noticing that the textLayer isn't correct, and it's unfortunately once again a problem with the `adjustType1ToUnicode` function. That's intended to help improve text-selection for fonts without a /ToUnicode-entry, and in many cases it does help (the original PR fixed lots of issues) however it's also caused some problems.

In order to improve text-selection in bug 1811668, we'll now properly ignore fonts that have a predefined *named* encoding specified since that's really the intention with PR 14050.
This commit is contained in:
Jonas Jenwald 2023-01-21 12:00:17 +01:00
parent 7b95788248
commit 40a46e4397
4 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/fonts.js
View File

@ -201,7 +201,7 @@ function adjustType1ToUnicode(properties, builtInEncoding) {
for (const charCode in builtInEncoding) { for (const charCode in builtInEncoding) {
if (properties.hasEncoding) { if (properties.hasEncoding) {
if ( if (
properties.differences.length === 0 || properties.baseEncodingName ||
properties.differences[charCode] !== undefined properties.differences[charCode] !== undefined
) { ) {
continue; // The font dictionary has an `Encoding`/`Differences` entry. continue; // The font dictionary has an `Encoding`/`Differences` entry.

1
test/pdfs/.gitignore vendored
View File

@ -399,6 +399,7 @@
!issue4461.pdf !issue4461.pdf
!issue4573.pdf !issue4573.pdf
!issue4722.pdf !issue4722.pdf
!bug1811668_reduced.pdf
!issue4800.pdf !issue4800.pdf
!issue9243.pdf !issue9243.pdf
!issue13147.pdf !issue13147.pdf

BIN
test/pdfs/bug1811668_reduced.pdf Normal file
View File

Binary file not shown.

6
test/test_manifest.json
View File

@ -1006,6 +1006,12 @@
"lastPage": 1, "lastPage": 1,
"type": "eq" "type": "eq"
}, },
{ "id": "bug1811668",
"file": "pdfs/bug1811668_reduced.pdf",
"md5": "87aa65d89aa0682cbe7b87152b884495",
"rounds": 1,
"type": "text"
},
{ "id": "issue8092", { "id": "issue8092",
"file": "pdfs/issue8092.pdf", "file": "pdfs/issue8092.pdf",
"md5": "e4f3376b35fd132580246c3db1fbd738", "md5": "e4f3376b35fd132580246c3db1fbd738",