From bc31a4be5df0c2238fd015cb7b0dfc9a264e607b Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sun, 16 Feb 2020 12:41:53 +0100 Subject: [PATCH] Enable the `unicorn/prefer-starts-ends-with` ESLint plugin rule This complements the existing `mozilla/use-includes-instead-of-indexOf` plugin rule, by also disallowing unnecessary regular expressions when comparing strings. Please see https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-starts-ends-with.md for additional information. --- .eslintrc | 1 + src/display/network_utils.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index 187da5ad6..d310cb199 100644 --- a/.eslintrc +++ b/.eslintrc @@ -38,6 +38,7 @@ "no-unsanitized/method": "error", "no-unsanitized/property": "error", "unicorn/no-array-instanceof": "error", + "unicorn/prefer-starts-ends-with": "error", // Possible errors "for-direction": "error", diff --git a/src/display/network_utils.js b/src/display/network_utils.js index 762a9f0c4..919e58afa 100644 --- a/src/display/network_utils.js +++ b/src/display/network_utils.js @@ -78,7 +78,7 @@ function extractFilenameFromHeader(getResponseHeader) { } function createResponseStatusError(status, url) { - if (status === 404 || (status === 0 && /^file:/.test(url))) { + if (status === 404 || (status === 0 && url.startsWith("file:"))) { return new MissingPDFException('Missing PDF "' + url + '".'); } return new UnexpectedResponseException(