Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clear some Arrays, rather than re-initialize them, in src/display/-code

Browse Source 
It's generally better to re-use the same Array, by clearing out all of its elements, rather than creating a new Array.
This commit is contained in:
Jonas Jenwald 2021-04-24 12:52:09 +02:00
parent da22146b95
commit 4078dd856c
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/display/network.js
View File

@ -350,7 +350,7 @@ class PDFNetworkStreamFullRequestReader {
for (const requestCapability of this._requests) { for (const requestCapability of this._requests) {
requestCapability.resolve({ value: undefined, done: true }); requestCapability.resolve({ value: undefined, done: true });
} }
this._requests = []; this._requests.length = 0;
} }
_onError(status) { _onError(status) {
@ -361,8 +361,8 @@ class PDFNetworkStreamFullRequestReader {
for (const requestCapability of this._requests) { for (const requestCapability of this._requests) {
requestCapability.reject(exception); requestCapability.reject(exception);
} }
this._requests = []; this._requests.length = 0;
this._cachedChunks = []; this._cachedChunks.length = 0;
} }
_onProgress(data) { _onProgress(data) {
@ -416,7 +416,7 @@ class PDFNetworkStreamFullRequestReader {
for (const requestCapability of this._requests) { for (const requestCapability of this._requests) {
requestCapability.resolve({ value: undefined, done: true }); requestCapability.resolve({ value: undefined, done: true });
} }
this._requests = []; this._requests.length = 0;
if (this._manager.isPendingRequest(this._fullRequestId)) { if (this._manager.isPendingRequest(this._fullRequestId)) {
this._manager.abortRequest(this._fullRequestId); this._manager.abortRequest(this._fullRequestId);
} }
@ -459,7 +459,7 @@ class PDFNetworkStreamRangeRequestReader {
for (const requestCapability of this._requests) { for (const requestCapability of this._requests) {
requestCapability.resolve({ value: undefined, done: true }); requestCapability.resolve({ value: undefined, done: true });
} }
this._requests = []; this._requests.length = 0;
this._close(); this._close();
} }
@ -494,7 +494,7 @@ class PDFNetworkStreamRangeRequestReader {
for (const requestCapability of this._requests) { for (const requestCapability of this._requests) {
requestCapability.resolve({ value: undefined, done: true }); requestCapability.resolve({ value: undefined, done: true });
} }
this._requests = []; this._requests.length = 0;
if (this._manager.isPendingRequest(this._requestId)) { if (this._manager.isPendingRequest(this._requestId)) {
this._manager.abortRequest(this._requestId); this._manager.abortRequest(this._requestId);
} }

6
src/display/transport_stream.js
View File

@ -230,7 +230,7 @@ class PDFDataTransportStreamReader {
for (const requestCapability of this._requests) { for (const requestCapability of this._requests) {
requestCapability.resolve({ value: undefined, done: true }); requestCapability.resolve({ value: undefined, done: true });
} }
this._requests = []; this._requests.length = 0;
} }
progressiveDone() { progressiveDone() {
@ -266,7 +266,7 @@ class PDFDataTransportStreamRangeReader {
for (const requestCapability of this._requests) { for (const requestCapability of this._requests) {
requestCapability.resolve({ value: undefined, done: true }); requestCapability.resolve({ value: undefined, done: true });
} }
this._requests = []; this._requests.length = 0;
} }
this._done = true; this._done = true;
this._stream._removeRangeReader(this); this._stream._removeRangeReader(this);
@ -295,7 +295,7 @@ class PDFDataTransportStreamRangeReader {
for (const requestCapability of this._requests) { for (const requestCapability of this._requests) {
requestCapability.resolve({ value: undefined, done: true }); requestCapability.resolve({ value: undefined, done: true });
} }
this._requests = []; this._requests.length = 0;
this._stream._removeRangeReader(this); this._stream._removeRangeReader(this);
} }
} }