Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Forbid sending of Dicts and Streams, with postMessage, when workers are disabled

Browse Source 
By default, i.e. with workers enabled, it's *purposely* not possible to send `Dict`s and `Stream`s from the worker-thread. This is achieved by defining a `function` on every `Dict` instance, since that ensures that [the structured clone algoritm](https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm) will throw an Error on `postMessage`.

However, with workers *disabled* we fall-back to the `LoopbackPort` implementation which just ignores any `function`s, thus incorrectly allowing sending of data which *should* be unclonable.
This commit is contained in:
Jonas Jenwald 2019-09-26 16:04:41 +02:00
parent cd909c531f
commit 3f8fee371b
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/display/api.js
View File

@ -1463,8 +1463,14 @@ class LoopbackPort {
while (!(desc = Object.getOwnPropertyDescriptor(p, i))) {
p = Object.getPrototypeOf(p);
}
if (typeof desc.value === 'undefined' ||
typeof desc.value === 'function') {
if (typeof desc.value === 'undefined') {
continue;
}
if (typeof desc.value === 'function') {
if (value.hasOwnProperty && value.hasOwnProperty(i)) {
throw new Error(
`LoopbackPort.postMessage - cannot clone: ${value[i]}`);
}
continue;
}
result[i] = cloneValue(desc.value);