Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix for lines (stroke) are rendered too thick (Bug 1743245)

Browse Source 
This commit fixes Bug 1743245 (Grided PDF file lines rendered too thick) which was created by a fix for  #12868 .
The lineWidth was set to round(1 * this._combinedScaleFactor) when the pixel is drawn as a parallelorgam with a height <1. This fix changes this to floor(1*this._combinedScaleFactor) .

This change shows a visual result comparable to Chrome and Acrobat.
Regarding the last PR 3 statements in canvas.js are affected and will change with this commit (stroke and paintChar).

renaming the reference files to naming comvention
This commit is contained in:
quaoaris 2022-01-25 00:26:45 +01:00
parent ede26bfe4a
commit 3f77d80f31
4 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/display/canvas.js
View File

@ -1770,7 +1770,7 @@ class CanvasGraphics {
// parallelogram where both heights are lower than 1 and not equal. // parallelogram where both heights are lower than 1 and not equal.
ctx.save(); ctx.save();
ctx.resetTransform(); ctx.resetTransform();
ctx.lineWidth = Math.round(this._combinedScaleFactor); ctx.lineWidth = Math.floor(this._combinedScaleFactor);
ctx.stroke(); ctx.stroke();
ctx.restore(); ctx.restore();
} else { } else {
@ -2040,7 +2040,7 @@ class CanvasGraphics {
) { ) {
if (resetLineWidthToOne) { if (resetLineWidthToOne) {
ctx.resetTransform(); ctx.resetTransform();
ctx.lineWidth = Math.round(this._combinedScaleFactor); ctx.lineWidth = Math.floor(this._combinedScaleFactor);
} }
ctx.stroke(); ctx.stroke();
} }
@ -2060,7 +2060,7 @@ class CanvasGraphics {
ctx.save(); ctx.save();
ctx.moveTo(x, y); ctx.moveTo(x, y);
ctx.resetTransform(); ctx.resetTransform();
ctx.lineWidth = Math.round(this._combinedScaleFactor); ctx.lineWidth = Math.floor(this._combinedScaleFactor);
ctx.strokeText(character, 0, 0); ctx.strokeText(character, 0, 0);
ctx.restore(); ctx.restore();
} else { } else {

1
test/pdfs/.gitignore vendored
View File

@ -471,6 +471,7 @@
!issue11442_reduced.pdf !issue11442_reduced.pdf
!issue11549_reduced.pdf !issue11549_reduced.pdf
!issue8097_reduced.pdf !issue8097_reduced.pdf
!bug1743245.pdf
!quadpoints.pdf !quadpoints.pdf
!transparent.pdf !transparent.pdf
!issue13931.pdf !issue13931.pdf

BIN
test/pdfs/bug1743245.pdf Normal file
View File

Binary file not shown.

6
test/test_manifest.json
View File

@ -4042,6 +4042,12 @@
"type": "eq", "type": "eq",
"annotations": true "annotations": true
}, },
{ "id": "bug1743245",
"file": "pdfs/bug1743245.pdf",
"md5": "01eadf118ec05fe02e91db63536d50f6",
"rounds": 1,
"type": "eq"
},
{ "id": "issue1002", { "id": "issue1002",
"file": "pdfs/issue1002.pdf", "file": "pdfs/issue1002.pdf",
"md5": "af62d6cd95079322d4af18edd960d15c", "md5": "af62d6cd95079322d4af18edd960d15c",