Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change how src/shared/compatibility.js is imported

Browse Source 
Currently the compatibility-file is loaded using a standard `import`-statement and while its code is enclosed in a pre-processor block, and thus is excluded in e.g. the MOZCENTRAL build-target, it still results in the *built* `pdf.js`/`pdf.worker.js` files having an effectively empty closure as a result.
By moving the checks from `src/shared/compatibility.js` and into `src/shared/util.js` instead, we can load the file using a build-time `require`-statement and thus avoid that closure.

Note that with these changes the compatibility-file will no longer be loaded in development mode, i.e. when `gulp server` is used. However, this shouldn't be a big issue given that none of its included polyfills could be loaded then anyway (since `require`-statements are being used) and that it's really only intended for the `legacy`-builds of the library.
This commit is contained in:
Jonas Jenwald 2022-09-25 16:18:11 +02:00
parent 2c38a14a14
commit 3e625994bd
2 changed files with 71 additions and 71 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/shared/compatibility.js
View File

@ -16,13 +16,6 @@
import { isNodeJS } from "./is_node.js"; import { isNodeJS } from "./is_node.js";
// Skip compatibility checks for modern builds and if we already ran the module.
if (
(typeof PDFJSDev === "undefined" || !PDFJSDev.test("SKIP_BABEL")) &&
!globalThis._pdfjsCompatibilityChecked
) {
globalThis._pdfjsCompatibilityChecked = true;
// Support: Node.js<16.0.0 // Support: Node.js<16.0.0
(function checkNodeBtoa() { (function checkNodeBtoa() {
if (globalThis.btoa || !isNodeJS) { if (globalThis.btoa || !isNodeJS) {
@ -91,4 +84,3 @@ if (
} }
require("core-js/web/structured-clone.js"); require("core-js/web/structured-clone.js");
})(); })();
}

10
src/shared/util.js
View File

@ -13,7 +13,15 @@
* limitations under the License. * limitations under the License.
*/ */
import "./compatibility.js"; // Skip compatibility checks for modern builds and if we already ran the module.
if (
typeof PDFJSDev !== "undefined" &&
!PDFJSDev.test("SKIP_BABEL") &&
!globalThis._pdfjsCompatibilityChecked
) {
globalThis._pdfjsCompatibilityChecked = true;
require("./compatibility.js");
}
const IDENTITY_MATRIX = [1, 0, 0, 1, 0, 0]; const IDENTITY_MATRIX = [1, 0, 0, 1, 0, 0];
const FONT_IDENTITY_MATRIX = [0.001, 0, 0, 0.001, 0, 0]; const FONT_IDENTITY_MATRIX = [0.001, 0, 0, 0.001, 0, 0];